fix(testing): remove --no-experimental-strip-types flag from @nx/jest/plugin + migrate to jest.config.cts if needed #33657
+897
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit 6ae1a0a
☁️ Nx Cloud last updated this comment at |
jaysoo
changed the title
jaysoo
changed the title
…/plugin + migrate to jest.config.cts if needed On Node.js v24+, the `@nx/jest/plugin` sets `--no-experimental-strip-types` in NODE_OPTIONS which causes an error: "node: --no-experimental-strip-types is not allowed in NODE_OPTIONS". Additionally, `jest.config.ts` files using ESM syntax (`export default`, `import`) fail to load correctly under Node.js type-stripping when the project is configured for CommonJS. - Remove the NODE_OPTIONS manipulation that adds `--no-experimental-strip-types` - Add a migration (22.2.0-beta.2) that converts `jest.config.ts` files from ESM to CJS syntax for projects using `@nx/jest/plugin` - The migration only runs when `@nx/jest/plugin` is registered in `nx.json` - Projects with `type: module` are warned as they're incompatible with the plugin - Files using ESM-only features (import.meta, top-level await) are skipped with a warning for manual conversion Fixes NXC-3541 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
![nx-cloud[bot]](https://avatars.githubusercontent.com/in/80458?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Nx Cloud has identified a flaky task in your failed CI:
🔂 Since the failure was identified as flaky, we reran your CI automatically.
🎓 Learn more about Self-Healing CI on nx.dev
leosvelperez
approved these changes
Dec 1, 2025
Comment on lines
140
to
145
| if ( | ||
| parent.kind === require('typescript').SyntaxKind.FunctionDeclaration || | ||
| parent.kind === require('typescript').SyntaxKind.FunctionExpression || | ||
| parent.kind === require('typescript').SyntaxKind.ArrowFunction || | ||
| parent.kind === require('typescript').SyntaxKind.MethodDeclaration | ||
| ) { |
Member
There was a problem hiding this comment.
nit: we could use ts.isFunctionLike(parent)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
On Node.js v24+, the
@nx/jest/pluginsets--no-experimental-strip-typesin NODE_OPTIONS which causes an error: "node: --no-experimental-strip-types is not allowed in NODE_OPTIONS".Additionally,
jest.config.tsfiles using ESM syntax (export default,import) fail to load correctly under Node.js type-stripping when the project is configured for CommonJS.Expected Behavior
--no-experimental-strip-typesjest.config.tsfiles from ESM to CJS syntax for projects using@nx/jest/plugin@nx/jest/pluginis registered innx.jsontype: moduleare warned as they're incompatible with the pluginDemo
https://www.loom.com/share/8a157a0b01d144ae8d6ae48b9b0cd0e4
Related Issue(s)
Closes NXC-3541