Skip to content

Do not try to put to blobstor on full write cache #3745

@roman-khimov

Description

@roman-khimov

Is your feature request related to a problem? Please describe.

I'm always frustrated when I'm thinking of write cache and blobstor relations. Currently we always try to put object to blobstor if putting to write cache fails.

Describe the solution you'd like

Don't do that in case write cache is full. If that's the case it's supposed to be flushing to blobstor at the maximum speed possible and additional threads pushing objects to blobstor directly can only slow it down. If it's full because it can't flush objects to blobstor trying this direct put doesn't help either.

Describe alternatives you've considered

Keep things as is. Current behavior is somewhat better for the case when write cache can't put objects to blobstor, but direct put somehow can. I don't see this happening, but who knows.

Additional context

#3744 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    I4No visible changesS3Minimally significantU4Nothing urgentenhancementImproving existing functionalityneofs-storageStorage node application issuesperformanceMore of something per second

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions