feat: enhance Claude GitHub Actions with advanced capabilities

ntindle · claude · ntindle · commit c0c32eb776bf · 2025-08-11T00:27:08.000-05:00
- Upgraded both workflows to use Claude Opus 4.1 for better analysis - Added comprehensive permissions for repository interaction - Configured extensive allowed_tools for testing and verification - Added project-specific custom instructions focusing on: - MathJS unitMath usage enforcement - TypeScript requirements - Code quality standards - Enhanced PR review prompts with detailed criteria - Added sticky comments for continuous PR review updates - Configured environment variables for proper context 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
diff --git a/.claude/settings.local.json b/.claude/settings.local.json
@@ -12,7 +12,10 @@
       "Bash(npx vite:*)",
       "Bash(npx tsc:*)",
       "Bash(gh pr view:*)",
-      "Bash(gh api:*)"
+      "Bash(gh api:*)",
+      "Bash(cp:*)",
+      "Fetch(*)",
+      "WebSearch(*)"
     ],
     "deny": []
   }
diff --git a/.github/workflows/claude-code-review.yml b/.github/workflows/claude-code-review.yml
@@ -20,10 +20,13 @@ jobs:
     
     runs-on: ubuntu-latest
     permissions:
-      contents: read
-      pull-requests: read
-      issues: read
-      id-token: write
+      contents: write  # Allow Claude to suggest file changes
+      pull-requests: write  # Allow Claude to create review comments
+      issues: write  # Allow Claude to create issues for findings
+      id-token: write  # For OIDC authentication
+      actions: read  # Read CI results
+      checks: write  # Create check runs for review status
+      statuses: write  # Update commit status
     
     steps:
       - name: Checkout repository
@@ -37,22 +40,45 @@ jobs:
         with:
           claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
 
-          # Optional: Specify model (defaults to Claude Sonnet 4, uncomment for Claude Opus 4.1)
-          # model: "claude-opus-4-1-20250805"
+          # Use Claude Opus 4.1 for thorough code reviews
+          model: "claude-opus-4-1-20250805"
 
-          # Direct prompt for automated review (no @claude mention needed)
+          # Comprehensive review prompt with project-specific focus
           direct_prompt: |
-            Please review this pull request and provide feedback on:
-            - Code quality and best practices
-            - Potential bugs or issues
-            - Performance considerations
-            - Security concerns
-            - Test coverage
+            Please perform a thorough code review of this pull request.
             
-            Be constructive and helpful in your feedback.
+            CRITICAL PROJECT RULES:
+            1. All calculations MUST use unitMath service (src/services/unitMath.ts) - NEVER use native JS math
+            2. All new code must be TypeScript with proper types
+            3. Use @/ import alias consistently
+            4. Follow existing patterns in the codebase
+            
+            Review for:
+            - **Math Operations**: Flag ANY use of +, -, *, /, Math.* in calculation code
+            - **TypeScript**: Proper typing, no 'any' types, interfaces defined
+            - **Code Quality**: DRY principles, readability, maintainability
+            - **Potential Bugs**: Edge cases, null checks, error handling
+            - **Performance**: Unnecessary re-renders, memoization opportunities
+            - **Security**: Input validation, XSS prevention, no exposed secrets
+            - **Test Coverage**: New features should have tests
+            - **Accessibility**: ARIA labels, keyboard navigation for UI changes
+            - **Gridfinity Logic**: Correct bin calculations, spacer generation
+            
+            Format your review with:
+            ✅ What looks good
+            ⚠️ Suggestions for improvement
+            🚨 Critical issues that must be fixed
+            
+            Be specific with line numbers and provide code examples for fixes.
 
-          # Optional: Use sticky comments to make Claude reuse the same comment on subsequent pushes to the same PR
-          # use_sticky_comment: true
+          # Use sticky comments to update review on new commits
+          use_sticky_comment: true
+          
+          # Enhanced permissions for review actions
+          additional_permissions: |
+            actions: read
+            checks: write
+            statuses: write
           
           # Optional: Customize review based on file types
           # direct_prompt: |
@@ -68,11 +94,27 @@ jobs:
           #   'Welcome! Please review this PR from a first-time contributor. Be encouraging and provide detailed explanations for any suggestions.' ||
           #   'Please provide a thorough code review focusing on our coding standards and best practices.' }}
           
-          # Optional: Add specific tools for running tests or linting
-          # allowed_tools: "Bash(npm run test),Bash(npm run lint),Bash(npm run typecheck)"
+          # Allow Claude to run verification commands during review
+          allowed_tools: |
+            Bash(npm run test:*)
+            Bash(npm run lint:*)
+            Bash(npm run typecheck:*)
+            Bash(npm run build:*)
+            Bash(npx vitest *)
+            Bash(npx eslint *)
+            Bash(npx tsc --noEmit)
+            Bash(git diff)
+            Bash(git log)
+            Bash(rg *)
+            Bash(grep -r)
+            Bash(find * -type f -name)
+            Bash(cat *)
+            Bash(head *)
+            Bash(tail *)
           
-          # Optional: Skip review for certain conditions
-          # if: |
-          #   !contains(github.event.pull_request.title, '[skip-review]') &&
-          #   !contains(github.event.pull_request.title, '[WIP]')
+          # Custom environment for review context
+          claude_env: |
+            REVIEW_MODE: strict
+            PROJECT: gridfinity-space-optimizer
+            TECH_STACK: React,TypeScript,Vite,TailwindCSS,MathJS
 
diff --git a/.github/workflows/claude.yml b/.github/workflows/claude.yml
@@ -19,11 +19,15 @@ jobs:
       (github.event_name == 'issues' && (contains(github.event.issue.body, '@claude') || contains(github.event.issue.title, '@claude')))
     runs-on: ubuntu-latest
     permissions:
-      contents: read
-      pull-requests: read
-      issues: read
-      id-token: write
-      actions: read # Required for Claude to read CI results on PRs
+      contents: write  # Allow Claude to create/edit files
+      pull-requests: write  # Allow Claude to create/update PRs
+      issues: write  # Allow Claude to create/update issues
+      id-token: write  # For OIDC authentication
+      actions: read  # Required for Claude to read CI results on PRs
+      checks: read  # Allow reading check runs
+      statuses: read  # Allow reading commit statuses
+      packages: read  # Allow reading packages if needed
+      discussions: write  # Allow Claude to participate in discussions
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
@@ -36,29 +40,76 @@ jobs:
         with:
           claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
 
-          # This is an optional setting that allows Claude to read CI results on PRs
+          # Enhanced permissions for Claude to interact with the repository
           additional_permissions: |
             actions: read
+            checks: read
+            statuses: read
+            packages: read
           
-          # Optional: Specify model (defaults to Claude Sonnet 4, uncomment for Claude Opus 4.1)
-          # model: "claude-opus-4-1-20250805"
+          # Use Claude Opus 4.1 for more complex tasks
+          model: "claude-opus-4-1-20250805"
           
           # Optional: Customize the trigger phrase (default: @claude)
           # trigger_phrase: "/claude"
           
           # Optional: Trigger when specific user is assigned to an issue
           # assignee_trigger: "claude-bot"
           
-          # Optional: Allow Claude to run specific commands
-          # allowed_tools: "Bash(npm install),Bash(npm run build),Bash(npm run test:*),Bash(npm run lint:*)"
+          # Allow Claude to run a comprehensive set of commands
+          allowed_tools: |
+            Bash(npm install)
+            Bash(npm ci)
+            Bash(npm run build:*)
+            Bash(npm run test:*)
+            Bash(npm run lint:*)
+            Bash(npm run typecheck:*)
+            Bash(npm run dev:*)
+            Bash(npm run preview:*)
+            Bash(npx *)
+            Bash(git status)
+            Bash(git diff:*)
+            Bash(git log:*)
+            Bash(git branch:*)
+            Bash(gh pr *)
+            Bash(gh issue *)
+            Bash(gh api *)
+            Bash(node *)
+            Bash(tsx *)
+            Bash(vitest:*)
+            Bash(eslint:*)
+            Bash(prettier:*)
+            Bash(tsc:*)
+            Bash(echo *)
+            Bash(cat *)
+            Bash(ls *)
+            Bash(pwd)
+            Bash(which *)
+            Bash(find * -type f -name)
+            Bash(grep -r)
+            Bash(rg *)
           
-          # Optional: Add custom instructions for Claude to customize its behavior for your project
-          # custom_instructions: |
-          #   Follow our coding standards
-          #   Ensure all new code has tests
-          #   Use TypeScript for new files
+          # Custom instructions for Claude to follow project standards
+          custom_instructions: |
+            Follow the CLAUDE.md file in the repository root for project guidelines
+            Use TypeScript for all new files
+            Follow existing code patterns and conventions
+            Use MathJS unitMath for all calculations (never use native JS math)
+            Ensure all new code has tests
+            Run linter and type checks before suggesting changes
+            Use the @/ import alias consistently
+            Prefer editing existing files over creating new ones
+            When reviewing PRs, check for:
+            - Proper use of unitMath instead of native math operations
+            - TypeScript type safety
+            - Test coverage for new features
+            - Consistent code style
+            - Performance implications
+            - Security considerations
           
-          # Optional: Custom environment variables for Claude
-          # claude_env: |
-          #   NODE_ENV: test
+          # Custom environment variables for Claude
+          claude_env: |
+            NODE_ENV: development
+            CI: true
+            VITE_PORT: 8080
 
