Thoughts on merging this into the packer code base?

[warroyo]

I was wondering if you are planning on merging this into the packer code base, there is currently an enhancement tagged for this exact functionality. It would be really great to have this integrated. Any thoughts on this?

[nukemberg]

i'm all for merging upstream. can you link me to the issue?

[warroyo]

awesome! here you go: hashicorp/packer#2193

[warroyo]

looks like someone created a pull request already for what looks like the exact same thing, you may want to take a look hashicorp/packer#2180

it has conflicts, but hopefully they get resolved soon

[nukemberg]

well, if that pull request is accepted i'm happy to put this project to rest :)

[warroyo]

it looks like it has not successfully merged yet. I will comment to see what is going on.

[jgkim]

@warroyo Actually, the pull request I made is a fork of the work by @avishai-ish-shalom. https://github.com/jgkim/packer-post-processor-docker-dockerfile

[nukemberg]

huh. why was a rewrite needed btw?

[jgkim]

@avishai-ish-shalom Basically I rewrote the code to follow the file structure of the packer code base, and I also fixed some bugs and added some features during rewriting.

[davidkarlsen]

ping

[nukemberg]

yes? still waiting for packer pull request by @jgkim to be merged

[davidkarlsen]

@avishai-ish-shalom There is an issue referenced in that pull request: hashicorp/packer#2180 which I am hitting. Any fix for that?

[jgkim]

@davidkarlsen, @jsoriano suggested a fix (jgkim#1) for that, but I did not merge it yet.