fix: misc

Author: nullishamy

package.json

@@ -13,6 +13,7 @@
         "build:watch": "tsc --watch --preserveWatchOutput",
         "cleaner": "ts-cleaner --dist lib --watch",
         "test": "jest",
+        "test:full": "COMPILE_EXAMPLES=1 jest",
         "test:watch": "jest --watch",
         "test:coverage": "jest --config jest.coverage.js",
         "test:coverage:watch": "jest --watchAll --config jest.coverage.js",

src/args.ts

@@ -37,10 +37,10 @@ export class Args<TArgTypes extends DefaultArgTypes = DefaultArgTypes> {
   // We store both a tree and a list so that we can iterate all values efficiently
   public arguments: PrefixTree<InternalArgument> = new PrefixTree()
   public argumentsList: InternalArgument[] = []
-  
+
   public commands: PrefixTree<InternalCommand> = new PrefixTree()
   public commandsList: InternalCommand[] = []
-  
+
   public resolvers: Resolver[] = []
   public builtins: Builtin[] = []
   public footerLines: string[] = []

src/builder/builtin.ts

@@ -22,7 +22,7 @@ export abstract class Builtin {
     return this
   }
 
-  abstract run (parser: Args<unknown>, flags: Record<string, string[]>, positionals: string[], trigger: string): Promise<void>
+  abstract run (parser: Args<{}>, flags: Record<string, string[]>, positionals: string[], trigger: string): Promise<void>
 
   helpInfo (): string {
     return `${this.commandTriggers.map(cmd => `${cmd} <...args>`).join(', ')} | ${this.argumentTriggers.map(arg => `--${arg}`).join(', ')}`

src/builder/default-builtins.ts

@@ -10,7 +10,7 @@ export class Help extends Builtin {
     this.onCommand('help')
   }
 
-  async run (parser: Args<unknown>): Promise<void> {
+  async run (parser: Args<{}>): Promise<void> {
     console.log(parser.help())
   }
 }
@@ -22,7 +22,7 @@ export class Version extends Builtin {
     this.onArgument('version')
   }
 
-  async run (parser: Args<unknown>): Promise<void> {
+  async run (parser: Args<{}>): Promise<void> {
     console.log(`${parser.opts.programName} (${parser.opts.programVersion})`)
   }
 }
@@ -34,7 +34,7 @@ export class ShellCompletion extends Builtin {
     this.onCommand('completion')
   }
 
-  async run (parser: Args<unknown>, __: Record<string, string[]>, positionals: string[]): Promise<void> {
+  async run (parser: Args<{}>, __: Record<string, string[]>, positionals: string[]): Promise<void> {
     positionals = positionals.slice(1)
     const [shell] = positionals
 

src/internal/parse/coerce.ts

@@ -494,7 +494,8 @@ export async function coerce (
         type: 'builtin',
         command: foundBuiltin,
         trigger
-      }
+      },
+      rest: undefined
     })
   }
 

test/ensure-examples-compile.test.ts

@@ -2,18 +2,37 @@ import fsp from 'fs/promises'
 import path from 'path'
 import { execSync } from 'child_process'
 
+interface ExecError {
+  status: number
+  signal: null
+  output: string[]
+  pid: number
+  stdout: string
+  stderr: string
+}
+
 describe('Example compilation', () => {
-  it('can compile the examples', async () => {
-    if (!process.env.GITHUB_ACTIONS) {
-      return
-    }
+  if (!process.env.COMPILE_EXAMPLES) {
+    it.skip('can compile the examples', () => {})
+    return
+  }
 
+  it('can compile the examples', async () => {
     const dir = path.join(__dirname, '..', 'examples')
     const examples = await fsp.readdir(dir)
 
     for (const example of examples) {
       console.time(example)
-      execSync(`npm run build --prefix ${path.join(dir, example)}`)
+
+      try {
+        execSync(`npm run build --prefix ${path.join(dir, example)}`, {
+          encoding: 'utf-8'
+        })
+      } catch (_err) {
+        const err = _err as ExecError
+        console.error('Example', example, 'failed to compile:', err.stdout)
+      }
+
       console.timeEnd(example)
     }
   })