We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using the C++ SpatialPooler, calling SpatialPooler.compute(encoder.encode(42)) will quietly do the very wrong thing because it's given a buffer of 8-bit integers and it thinks it's getting a buffer of 32-bit integers. See: https://discourse.numenta.org/t/inconsistency-between-spatialpooler-in-nupic-and-nupic-bindings/1549/10?u=mrcslws
SpatialPooler.compute(encoder.encode(42))
I think this line should be changed to use numpy.uint32: https://github.com/numenta/nupic/blob/6924a904644bbb8cdba6ca7a62050cf8456614f8/src/nupic/encoders/base.py#L30
numpy.uint32
Anyone who wants encoders to use fewer bits can explicitly use encodeIntoArray. For encode, we should use a default that works with the SpatialPooler.
encodeIntoArray
encode
The text was updated successfully, but these errors were encountered:
Related C++ issue numenta/nupic.core-legacy#961
Sorry, something went wrong.
No branches or pull requests
Using the C++ SpatialPooler, calling
SpatialPooler.compute(encoder.encode(42))
will quietly do the very wrong thing because it's given a buffer of 8-bit integers and it thinks it's getting a buffer of 32-bit integers. See: https://discourse.numenta.org/t/inconsistency-between-spatialpooler-in-nupic-and-nupic-bindings/1549/10?u=mrcslwsI think this line should be changed to use
numpy.uint32
: https://github.com/numenta/nupic/blob/6924a904644bbb8cdba6ca7a62050cf8456614f8/src/nupic/encoders/base.py#L30Anyone who wants encoders to use fewer bits can explicitly use
encodeIntoArray
. Forencode
, we should use a default that works with the SpatialPooler.The text was updated successfully, but these errors were encountered: