Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Netlify Docs preview #857

Closed
SeanKilleen opened this issue Dec 4, 2023 · 3 comments
Closed

Add Netlify Docs preview #857

SeanKilleen opened this issue Dec 4, 2023 · 3 comments

Comments

@SeanKilleen
Copy link
Member

SeanKilleen commented Dec 4, 2023 •
edited
Loading

I should have created an issue for this, oops! So I'm doing it a little backwards.

Prior to creating this issue:
@SeanKilleen SeanKilleen mentioned this issue Dec 4, 2023
Merged
@SeanKilleen
Copy link
Member Author

🎉 It works!

✅ Netlify preview Generated for every PR commit
✅ GitHub Environment created for every PR's deployment preview
✅ PR comment made with preview comment
✅ PR comment updated on every subsequent commit (rather than multiple comments)
✅ GitHub Preview Env deleted on PR closure.

With that, closing this.

@SeanKilleen SeanKilleen mentioned this issue Dec 4, 2023
Closed
@SeanKilleen SeanKilleen reopened this Dec 4, 2023
@SeanKilleen
Copy link
Member Author

Re-opening this because I screwed up the permissions and I have to use the PAT in all the environment-related places.

@SeanKilleen SeanKilleen mentioned this issue Dec 4, 2023
Merged
@SeanKilleen
Copy link
Member Author

OK, this has now succeeded and I think we're OK. Closing once more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SeanKilleen