-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Engine does not signal termination when forced shutdown is used #578
Comments
Hello, Are there any plans to fix this issue? Best regards, |
@MartinZec On the TestCentric side, I marked TestCentric/testcentric-guy#139 closed, having patched the private engine build it uses. Does that not work for you? |
This does not work for me. In my case I have an infinite loop inside the test (like a while(1)). This loop is not interrupted by the testcentric stop button. I get a prompt "Do you want to cancel the running test?" form testcentric, but the while(1) is still running. OneTimeTearDown and TearDown are not called since the while(1) is still blocking. |
That makes sense. The TestCentric "fix" is to wait 5 seconds for a cooperative cancellation (i.e. running teardowns) and then do a forced shutdown. |
For me it waits forever |
In that case, could you review and comment on TestCentric/testcentric-gui#139 ? See also TestCentric/testcentric-gui#374 dealing with the teardown problem. |
When using
ITestRunnerStopRun(true)
to force a shutdown, the engine does not change the Runner status, so it appears that tests are still running. No events are signaled to indicate that the run is complete or cancelled. A client that is waiting for the termination to be complete has to wait forever.See TestCentric/testcentric-gui#139
In addition to reporting status properly, it would also be convenient if the engine had a way to start with a cooperative shutdown and then switch to a forced shutdown after a period of time. Otherwise, every client has to implement that logic.
The text was updated successfully, but these errors were encountered: