Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing the nunit.engine adds nunit.engine.nuget.addins to the csproj #723

Open
ChrisMaddock opened this issue Jan 4, 2020 · 3 comments
Labels
Bug High Priority Needs Confirmation V4 All issues related to V4 - use -label:V4 to get non-V4 issues
Milestone

Comments

@ChrisMaddock
Copy link
Member

image

This isn't intentional. This addins file is just linked to the file in the package itself, which means any edits would be lost on package restore. We probably need to fix this for 3.11.

@ChrisMaddock ChrisMaddock added this to the 3.11 milestone Jan 4, 2020
@ChrisMaddock ChrisMaddock self-assigned this Jan 4, 2020
@CharliePoole
Copy link
Member

May just be a doc fix. Users should not edit our addins files but should simply add their own in addition.

@ChrisMaddock
Copy link
Member Author

@jnm2 - I think this has happened with the change to contentFiles. Any idea's how we might prevent this? I've had a dig, but not much luck. 😢

I think we really just want this file to be copied over to bin like the agents - but not be shown as part of the VS project. This is using PackageReference, btw.

@ChrisMaddock ChrisMaddock modified the milestones: 3.11, 3.12 Jan 26, 2020
@ChrisMaddock ChrisMaddock removed their assignment Jan 26, 2020
@ChrisMaddock ChrisMaddock removed this from the 3.12 milestone Jun 18, 2020
@CharliePoole
Copy link
Member

This was once confirmed but we need to re-confirm using the latest release.

@CharliePoole CharliePoole added this to the 4.0 milestone Mar 9, 2022
@CharliePoole CharliePoole added the V4 All issues related to V4 - use -label:V4 to get non-V4 issues label Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug High Priority Needs Confirmation V4 All issues related to V4 - use -label:V4 to get non-V4 issues
Projects
None yet
Development

No branches or pull requests

2 participants