Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with ExtensionService selecting highest-possible-framework version of extensions #838

Closed
ChrisMaddock opened this issue Nov 28, 2020 · 3 comments

Comments

@ChrisMaddock
Copy link
Member

From nunit/teamcity-event-listener#75.

The TeamCity extension has two versions, one which targets .NET 2.0, and one which targets .NET Standard 2.0. The intended engine behaviour is that it should chose the extension targeting the highest possible framework version.

So in this case, when running the console in .NET 4.6.2 or higher, the .NET Standard 2.0 extension should be selected. What I think actually happens is that the engine simply compares "2.0" to "2.0" to chose the highest framework.

In this case, we somehow need to make it aware that .NET Standard 2.0 is "higher" that .NET Framework 2.0. This needs thinking about in terms of how we create the target "hierarchy", so it doesn't become a maintenance burden.

@CharliePoole
Copy link
Member

@NikolayPianikov
What's the status of this in your view? Do we still need to do something for the 4.0 console or have you changed the extension?

@NikolayPianikov
Copy link
Member

@CharliePoole actually we have no any complaints about it from our customers, so I suppose this ticket could be closed

@CharliePoole
Copy link
Member

Thanks @NikolayPianikov I'll close this. Let me know if you see any problems come up as the 4.0 development progresses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants