Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add completions support to this plugin #69

Closed
EmilyGraceSeville7cf opened this issue Nov 19, 2022 · 5 comments
Closed

Add completions support to this plugin #69

EmilyGraceSeville7cf opened this issue Nov 19, 2022 · 5 comments

Comments

@EmilyGraceSeville7cf
Copy link
Contributor

Automatically obtain all available completions and use them while editing scripts: suggesting command options for instance. It would be a neat feature. 😄

@fdncred
Copy link
Contributor

fdncred commented Nov 19, 2022

We originally had vscode suggestions for subcommands but the thing that makes it difficult in nushell is that subcommands are delimited by space. So, every space you type would trigger the subcommand list. This because annoying so we removed it. I think the code may still be there but commented out. I'm sure there's a better way to do it.

Generating parameters and such may be different though.

We'd accept a PR for any piece of this, assuming it works better than the original implementation. :)

@EmilyGraceSeville7cf
Copy link
Contributor Author

EmilyGraceSeville7cf commented Nov 19, 2022

What about generating completions by some shortcut for instance Ctrl+Space? I don't know, maybe I have to look how it's implemented in PowerShell.

We'd accept a PR for any piece of this, assuming it works better than the original implementation. :)

I am not sure I personally can do it.

@fdncred
Copy link
Contributor

fdncred commented Nov 19, 2022

What about generating completions by some shortcut for instance Ctrl+Space?

We could do something like that but a big problem is that we don't have a LSP right now. So, I think that means that we'd have to put all these things in typescript i.e. all options, command parameters, etc. Or, we'd have to shell out and call nushell for each of these and parse the return - probably would be non-performant.

@fdncred
Copy link
Contributor

fdncred commented Apr 18, 2023

Added. Tracking issue is here #91

@fdncred fdncred closed this as completed Apr 18, 2023
@EmilyGraceSeville7cf
Copy link
Contributor Author

EmilyGraceSeville7cf commented Apr 18, 2023

Many thanks! ❤️ 🚀 It may be a game changer for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants