Thanks for the bug report @john43252345!

Triage Outcome

User Impact: Very low

This bug occurs in the privacy opt-out toggle in the settings page. It happens if adblock is turned on.

Cause of bug

Offending function:withTracker in onToggleTracking in SettingsContainer

Everything in withTracker only runs if matomo (the tool we use for analytics) is initialized. See bootstrapping/matomo.ts.

If adblock is turned on, matomo never initializes, and the opting out of tracking is deferred in a queuedTasks array, never to be run.

Steps to resolve

Difficulty: Low

Don't use withTracker
Write a useMatomo hook to get the matomo object.
In SettingsContainer, check if matomo is initialized using useMatomo.
- if not initialized: show opt-out by default
- if initialized: use current behavior
Disable the toggle if matomo is not initialized (so that adblock users can't interact with it)
Refactor onToggleTracking to use matomo from useMatomo.
Can some kind soul rename all instance of "mamoto" to "matomo" 😂 (sorry @ZhangYiJiang but your typos around the codebase kinda irks me slightly 😂)

Tests

(If you know how to write unit tests.) Write unit tests with RTL. Assert behaviour depending on whether the matomo object is present or not.

Testing

Take note that matomo is by default not initialized in the dev build. To properly test this, you might need to comment out the relevant code to ensure initializeMamoto() is run in the dev build in entry/main.tsx. You will also need an adblocker of your choice that allows you to toggle on and off. I personally use uBlock Origin. Up to you.

If anyone wants to take it up, do leave a comment here!

Privacy Opt-Out not clickable #3254

Description

Describe the bug

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions