Remove extraneous parseStreamAsJson function

Author: zwliew

README.md

@@ -1,4 +1,7 @@
 # Serverless Functions
 
-Serverless functions that NUSMods uses. These used to run on https://code.stdlib.com/ but that is dead so now we're looking into other alternatives.
-For one, venue-github-hook is now hosted on Cloudflare Workers.
+Serverless functions that NUSMods uses. They run on Cloudflare Workers.
+Currently, we have two functions:
+
+- [venue-github-hook](./nusmods-venue-github-hook/) for handling venue data updates.
+- [module-error-reporting](./nusmods-module-error-reporting/) for handling course error reports.

nusmods-module-error-reporting/index.js

@@ -9,22 +9,6 @@ async function getFacultyEmail(contactId) {
     return contact ? contact.email : null;
 }
 
-async function parseStreamAsJson(stream) {
-    const chunks = [];
-    for await (const chunk of stream) {
-        chunks.push(chunk);
-    }
-    const totalLen = chunks.reduce((acc, chunk) => acc + chunk.length, 0);
-    if (totalLen === 0) {
-        return null;
-    }
-    const mergedChunks = new Uint8Array(totalLen);
-    for (let i = 0, offset = 0; i < chunks.length; offset += chunks[i].length, ++i) {
-        mergedChunks.set(chunks[i], offset);
-    }
-    return JSON.parse(new TextDecoder().decode(mergedChunks));
-}
-
 /**
  * @typedef {Object} Env
  */
@@ -51,7 +35,7 @@ export default {
             return new Response(null, { status: 400, headers: respHeaders });
         }
 
-        const parsedBody = await parseStreamAsJson(request.body);
+        const parsedBody = await request.json();
         if (parsedBody === null) {
             return new Response(null, { status: 400, headers: respHeaders });
         }

nusmods-venue-github-hook/index.js

@@ -15,22 +15,6 @@ function toDataList(data) {
   return unorderedList(dataList);
 }
 
-async function parseStreamAsJson(stream) {
-  const chunks = [];
-  for await (const chunk of stream) {
-    chunks.push(chunk);
-  }
-  const totalLen = chunks.reduce((acc, chunk) => acc + chunk.length, 0);
-  if (totalLen === 0) {
-    return null;
-  }
-  const mergedChunks = new Uint8Array(totalLen);
-  for (let i = 0, offset = 0; i < chunks.length; offset += chunks[i].length, ++i) {
-    mergedChunks.set(chunks[i], offset);
-  }
-  return JSON.parse(new TextDecoder().decode(mergedChunks));
-}
-
 /**
  * @typedef {Object} Env
  */
@@ -57,7 +41,7 @@ export default {
       return new Response(null, { status: 400, headers: respHeaders });
     }
 
-    const parsedBody = await parseStreamAsJson(request.body);
+    const parsedBody = await request.json();
     if (parsedBody === null) {
       return new Response(null, { status: 400, headers: respHeaders });
     }
@@ -68,7 +52,7 @@ export default {
 
     try {
       const response = await fetch('https://github.nusmods.com/venues');
-      const currentVenues = await parseStreamAsJson(response.body);
+      const currentVenues = await response.json();
       currentVenue = currentVenues[venue];
     } catch (e) {
       currentVenueError = e;