.github/workflows/latest-npm.yml

@@ -55,11 +55,15 @@ jobs:
             registry.npmjs.org:443
       - uses: actions/checkout@v3
       - uses: ljharb/actions/node/install@main
-        name: 'nvm install-latest-npm'
+        name: 'install node'
         with:
           node-version: ${{ matrix.node-version }}
           skip-ls-check: true
           skip-install: true
+          skip-latest-npm: true
+      - run: npm --version
+      - run: '. ./nvm.sh ; nvm install-latest-npm'
+        name: 'nvm install-latest-npm'
       - run: npm --version
 
   node:

.travis.yml

@@ -1,5 +1,5 @@
 language: generic
-dist: xenial
+dist: focal
 addons:
   apt:
     packages:
@@ -22,13 +22,46 @@ before_install:
   - bash --version | head
   - zsh  --version
   - dpkg -s dash | grep ^Version | awk '{print $2}'
+  - pyenv local 3.9 || echo 'pyenv failed'
 install:
   - if [ -z "${SHELLCHECK-}" ]; then nvm install 16 && nvm unalias default && npm install && npm prune && npm ls urchin doctoc eclint dockerfile_lint; fi
   - '[ -z "$WITHOUT_CURL" ] || sudo apt-get remove curl -y'
 script:
-  - if [ -n "${SHELL-}" ] && [ -n "${TEST_SUITE}" ]; then if [ "${TEST_SUITE}" = 'installation_iojs' ]; then travis_retry make TEST_SUITE=$TEST_SUITE URCHIN="$(npm bin)/urchin" test-$SHELL ; else make TEST_SUITE=$TEST_SUITE URCHIN="$(npm bin)/urchin" test-$SHELL; fi; fi
+  - if [ -n "${SHELL-}" ] && [ -n "${TEST_SUITE}" ]; then if [ "${TEST_SUITE}" = 'installation_iojs' ] || [ "${TEST_SUITE}" = 'xenial' ]; then travis_retry make TEST_SUITE=$TEST_SUITE URCHIN="$(npm bin)/urchin" test-$SHELL ; else make TEST_SUITE=$TEST_SUITE URCHIN="$(npm bin)/urchin" test-$SHELL; fi; fi
 before_cache:
   - if [ -n "$WITHOUT_CURL" ]; then sudo apt-get install curl -y ; fi
+jobs:
+  include:
+    - env: SHELL=bash TEST_SUITE=installation_node
+      dist: xenial
+    - env: SHELL=bash TEST_SUITE=installation_node WITHOUT_CURL=1
+      dist: xenial
+    - env: SHELL=sh TEST_SUITE=installation_node
+      dist: xenial
+    - env: SHELL=sh TEST_SUITE=installation_node WITHOUT_CURL=1
+      dist: xenial
+    - env: SHELL=dash TEST_SUITE=installation_node
+      dist: xenial
+    - env: SHELL=dash TEST_SUITE=installation_node WITHOUT_CURL=1
+      dist: xenial
+    - env: SHELL=zsh TEST_SUITE=installation_node
+      dist: xenial
+    - env: SHELL=zsh TEST_SUITE=installation_node WITHOUT_CURL=1
+      dist: xenial
+    #- env: SHELL=ksh TEST_SUITE=installation_node
+    #  dist: xenial
+    #- env: SHELL=ksh TEST_SUITE=installation_node WITHOUT_CURL=1
+    #  dist: xenial
+    - env: SHELL=bash TEST_SUITE=xenial
+      dist: xenial
+    - env: SHELL=sh TEST_SUITE=xenial
+      dist: xenial
+    - env: SHELL=dash TEST_SUITE=xenial
+      dist: xenial
+    - env: SHELL=zsh TEST_SUITE=xenial
+      dist: xenial
+    #- env: SHELL=ksh TEST_SUITE=xenial
+    #  dist: xenial
 env:
   global:
     - CXX=g++
@@ -53,16 +86,6 @@ env:
     - SHELL=bash TEST_SUITE=slow
     - SHELL=zsh TEST_SUITE=slow
     #  - SHELL=ksh TEST_SUITE=slow
-    - SHELL=sh TEST_SUITE=installation_node
-    - SHELL=sh TEST_SUITE=installation_node WITHOUT_CURL=1
-    - SHELL=dash TEST_SUITE=installation_node
-    - SHELL=dash TEST_SUITE=installation_node WITHOUT_CURL=1
-    - SHELL=bash TEST_SUITE=installation_node
-    - SHELL=bash TEST_SUITE=installation_node WITHOUT_CURL=1
-    - SHELL=zsh TEST_SUITE=installation_node
-    - SHELL=zsh TEST_SUITE=installation_node WITHOUT_CURL=1
-    #  - SHELL=ksh TEST_SUITE=installation_node
-    #  - SHELL=ksh TEST_SUITE=installation_node WITHOUT_CURL=1
     - SHELL=sh TEST_SUITE=installation_iojs
     - SHELL=sh TEST_SUITE=installation_iojs WITHOUT_CURL=1
     - SHELL=dash TEST_SUITE=installation_iojs

nvm.sh

@@ -332,6 +332,10 @@ nvm_install_latest_npm() {
       nvm_echo '* `npm` `v6.9` is the last version that works on `node` `v6.0.x`, `v6.1.x`, `v9.0.x`, `v9.1.x`, or `v9.2.x`'
       $NVM_NPM_CMD install -g npm@6.9
     elif [ $NVM_IS_10_OR_ABOVE -eq 0 ]; then
+      if nvm_version_greater 4.4.4 "${NPM_VERSION}"; then
+        nvm_echo '* `npm` `v4.4.4` or later is required to install npm v6.14.18'
+        $NVM_NPM_CMD install -g npm@4
+      fi
       nvm_echo '* `npm` `v6.x` is the last version that works on `node` below `v10.0.0`'
       $NVM_NPM_CMD install -g npm@6
     elif \
@@ -373,6 +377,7 @@ if [ -z "${NVM_DIR-}" ]; then
     # shellcheck disable=SC2169,SC3054
     NVM_SCRIPT_SOURCE="${BASH_SOURCE[0]}"
   fi
+  # shellcheck disable=SC2086
   NVM_DIR="$(nvm_cd ${NVM_CD_FLAGS} "$(dirname "${NVM_SCRIPT_SOURCE:-$0}")" >/dev/null && \pwd)"
   export NVM_DIR
 else
@@ -693,6 +698,7 @@ ${NVM_LS_REMOTE_POST_MERGED_OUTPUT}" | nvm_grep -v "N/A" | command sed '/^ *$/d'
   fi
   # the `sed` is to remove trailing whitespaces (see "weird behavior" ~25 lines up)
   nvm_echo "${VERSIONS}" | command sed 's/ *$//g'
+  # shellcheck disable=SC2317
   return $NVM_LS_REMOTE_EXIT_CODE || $NVM_LS_REMOTE_IOJS_EXIT_CODE
 }
 
@@ -886,18 +892,6 @@ nvm_wrap_with_color_code() {
   fi
 }
 
-nvm_wrap_with_color_code() {
-  local CODE
-  CODE="$(nvm_print_color_code "${1}" 2>/dev/null ||:)"
-  local TEXT
-  TEXT="${2-}"
-  if nvm_has_colors && [ -n "${CODE}" ]; then
-    nvm_echo_with_colors "\033[${CODE}${TEXT}\033[0m"
-  else
-    nvm_echo "${TEXT}"
-  fi
-}
-
 nvm_print_color_code() {
   case "${1-}" in
     '0') return 0 ;;
@@ -3801,6 +3795,7 @@ nvm() {
       nvm_ensure_version_installed "${provided_version}"
       EXIT_CODE=$?
       if [ "${EXIT_CODE}" != "0" ]; then
+        # shellcheck disable=SC2086
         return $EXIT_CODE
       fi
 
@@ -3957,6 +3952,7 @@ nvm() {
       nvm_ensure_version_installed "${provided_version}"
       EXIT_CODE=$?
       if [ "${EXIT_CODE}" != "0" ]; then
+        # shellcheck disable=SC2086
         return $EXIT_CODE
       fi
       local NVM_VERSION_DIR

test/fast/Aliases/nvm_list_aliases works with LTS aliases

@@ -9,14 +9,20 @@ die () {
 
 set -e
 
+MOCKS_DIR="../Unit tests/mocks"
+
+# sample output at the time the test was written
+TAB_PATH="$MOCKS_DIR/nodejs.org-dist-index.tab"
+nvm_download() {
+  cat "$TAB_PATH"
+}
+
 nvm_alias_path() {
   nvm_echo "../../../alias"
 }
 
 nvm ls-remote >/dev/null || die 'nvm ls-remote (to populate LTS aliases) failed'
 
-MOCKS_DIR="../Unit tests/mocks"
-
 EXPECTED_OUTPUT="$(cat "$MOCKS_DIR/lts-star.txt")"
 STDOUT_OUTPUT="$(nvm_list_aliases "lts/*")"
 STDERR_OUTPUT="$(nvm_list_aliases "lts/*" 2>&1 >/dev/null)"

test/xenial/install from source

@@ -0,0 +1,29 @@
+#!/bin/sh
+
+set -ex
+
+die () { echo "$@" ; exit 1; }
+
+set +e # TODO: fix
+\. ../../nvm.sh
+set -e
+
+nvm deactivate || die 'deactivate failed'
+
+nvm unalias default || die 'unable to unalias default'
+
+NVM_TEST_VERSION=v0.10.7
+
+# Remove the stuff we're clobbering.
+nvm uninstall "${NVM_TEST_VERSION}" || die 'nvm uninstall failed'
+
+# Install from source
+nvm install -s "${NVM_TEST_VERSION}" || die "'nvm install -s ${NVM_TEST_VERSION}' failed"
+
+# Check
+[ -d ../../$NVM_TEST_VERSION ] || die "../../${NVM_TEST_VERSION} is not a directory"
+nvm run $NVM_TEST_VERSION --version | grep $NVM_TEST_VERSION || "'nvm run ${NVM_TEST_VERSION} --version | grep ${NVM_TEST_VERSION}' failed"
+
+# ensure default is set
+NVM_CURRENT_DEFAULT="$(nvm_alias default)"
+[ "${NVM_CURRENT_DEFAULT}" = "${NVM_TEST_VERSION}" ] || die "wrong default alias: $(nvm alias)"

test/xenial/install from source with thread parameter

@@ -0,0 +1,33 @@
+#!/bin/sh
+
+die () { echo "$@" ; exit 1; }
+
+\. ../../nvm.sh
+
+NVM_TEST_VERSION=v0.10.7
+
+# STAGE 1 #
+
+# Remove the stuff we're clobbering.
+[ -e ../../$NVM_TEST_VERSION ] && rm -R ../../$NVM_TEST_VERSION
+
+# Install from source with 1 make job
+nvm install -s -j 1 $NVM_TEST_VERSION || die "'nvm install -s $NVM_TEST_VERSION' failed"
+
+# Check
+[ -d ../../$NVM_TEST_VERSION ]
+nvm run $NVM_TEST_VERSION --version | grep $NVM_TEST_VERSION || "'nvm run $NVM_TEST_VERSION --version | grep $NVM_TEST_VERSION' failed"
+
+
+
+# STAGE 2 #
+
+# Remove the stuff we're clobbering.
+[ -e ../../$NVM_TEST_VERSION ] && rm -R ../../$NVM_TEST_VERSION
+
+# Install from source with 2 make jobs (and swapped arg order)
+nvm install -j 2 -s $NVM_TEST_VERSION || die "'nvm install -s $NVM_TEST_VERSION' failed"
+
+# Check
+[ -d ../../$NVM_TEST_VERSION ]
+nvm run $NVM_TEST_VERSION --version | grep $NVM_TEST_VERSION || "'nvm run $NVM_TEST_VERSION --version | grep $NVM_TEST_VERSION' failed"

test/xenial/install from source without V8 snapshot for ARM

@@ -0,0 +1,25 @@
+#!/bin/sh
+
+die () { echo "$@" ; exit 1; }
+
+\. ../../nvm.sh
+
+NVM_TEST_VERSION=v0.10.7
+
+# Remove the stuff we're clobbering.
+[ -e ../../$NVM_TEST_VERSION ] && rm -R ../../$NVM_TEST_VERSION
+
+# Fake ARM arch
+nvm_get_arch() {
+  echo "armv7l"
+}
+
+# Install from source
+nvm install -s $NVM_TEST_VERSION || die "'nvm install -s $NVM_TEST_VERSION' failed"
+
+# Check Install
+[ -d ../../$NVM_TEST_VERSION ]
+node --version | grep $NVM_TEST_VERSION || "'node --version | grep $NVM_TEST_VERSION' failed"
+
+# Check V8 snapshot isn't compiled
+node -p "if(! process.config.variables.v8_use_snapshot) { console.log('no-snapshot'); }" | grep "no-snapshot" || "'node -p \"if(! process.config.variables.v8_use_snapshot) { console.log('no-snapshot'); }\" | grep \"no-snapshot\"' failed"

test/xenial/install hook

@@ -0,0 +1,45 @@
+#!/bin/sh
+
+die () { echo "$@" ; exit 1; }
+
+. ../../nvm.sh
+
+VERSION='v0.11.0'
+VERSION_PATH="$(nvm_version_path "${VERSION}")"
+
+succeed() {
+  nvm_echo "$@"
+  NVM_INSTALL_THIRD_PARTY_HOOK= nvm install "${VERSION}"
+}
+
+fail() {
+  succeed "$@"
+  return 11
+}
+
+! nvm_is_version_installed "${VERSION}" || nvm uninstall "${VERSION}" || die 'uninstall failed'
+
+# an existing but empty VERSION_PATH directory should not be enough to satisfy nvm_is_version_installed
+rm -rf "${VERSION_PATH}"
+mkdir -p "${VERSION_PATH}"
+nvm_is_version_installed "${VERSION}" && die 'nvm_is_version_installed check not strict enough'
+rmdir "${VERSION_PATH}"
+
+OUTPUT="$(NVM_INSTALL_THIRD_PARTY_HOOK=succeed nvm install "${VERSION}")"
+USE_OUTPUT="$(nvm use "${VERSION}")"
+EXPECTED_OUTPUT="${VERSION} node std binary ${VERSION_PATH}
+Downloading and installing node ${VERSION}...
+${USE_OUTPUT}"
+
+[ "${OUTPUT}" = "${EXPECTED_OUTPUT}" ] || die "expected >${EXPECTED_OUTPUT}<; got >${OUTPUT}<"
+
+! nvm_is_version_installed "${VERSION}" || nvm uninstall "${VERSION}" || die 'uninstall 2 failed'
+
+OUTPUT="$(NVM_INSTALL_THIRD_PARTY_HOOK=fail nvm install "${VERSION}" || echo 'failed')"
+USE_OUTPUT="$(nvm use "${VERSION}")"
+EXPECTED_OUTPUT="${VERSION} node std binary ${VERSION_PATH}
+Downloading and installing node ${VERSION}...
+${USE_OUTPUT}
+failed"
+
+[ "${OUTPUT}" = "${EXPECTED_OUTPUT}" ] || die "expected >${EXPECTED_OUTPUT}<; got >${OUTPUT}<"