Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to become a contributor #12

Open
nyuichi opened this issue Dec 14, 2019 · 0 comments
Open

How to become a contributor #12

nyuichi opened this issue Dec 14, 2019 · 0 comments

Comments

@nyuichi
Copy link
Owner

nyuichi commented Dec 14, 2019

Please send a message saying "let me join!" in this thread if you wish to become a contributor of this project. Note that, however, being a contributor of this repository does not mean you are fully able to push arbitrary changes to master. Usually we follow the following workflow to make changes in the code in master:

  • create a pull request
  • get it reviewed from a contributor who knows well the code base you are changing
  • once your reviewer approved your pull request, merge it to master

That is, even a non contributor can send us pull requests and even a contributor has to create a pull request whenever, so becoming a contributor is not very important if you just want to send us changes. Instead contributors are assigned reviewing tasks and responsible for checking the given patch works fine.

@nyuichi nyuichi pinned this issue Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant