Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: spaces between top-level forms being removed #103

Closed
oakmac opened this issue Oct 5, 2024 · 3 comments
Closed

bug: spaces between top-level forms being removed #103

oakmac opened this issue Oct 5, 2024 · 3 comments
Assignees
@oakmac
Labels
bug Something isn't working help wanted Extra attention is needed v1 blocker Required for a v1.0.0 release

Comments

@oakmac
Copy link
Owner

oakmac commented Oct 5, 2024

Follow-up from Issue #102

This is incorrect behavior. The spaces between these top-level forms should not be removed.
@oakmac oakmac self-assigned this Oct 5, 2024
@oakmac oakmac added bug Something isn't working v1 blocker Required for a v1.0.0 release labels Oct 5, 2024
@oakmac oakmac mentioned this issue Oct 5, 2024
Closed
@oakmac
Copy link
Owner Author

oakmac commented Oct 6, 2024

I am having trouble replicating this issue @holyjak.

When I run Standard Clojure Style v0.5.0 on this file I see this output. That output looks correct to me and does not have the linebreaks between top-level forms removed like in your link from Issue #102. Thoughts?

@oakmac
Copy link
Owner Author

oakmac commented Oct 7, 2024

Odd: when I clone wolframite locally and run Standard Clojure Style through the CLI tool I do see the same result as scicloj/wolframite#134

Something is broken somewhere; this needs more investigation.

@oakmac oakmac mentioned this issue Oct 7, 2024
Closed
@oakmac oakmac added the help wanted Extra attention is needed label Oct 19, 2024
oakmac added a commit that referenced this issue Oct 19, 2024
@oakmac
GitHub Issue #103 - convert CRLF to LF
d3247cc
@oakmac oakmac mentioned this issue Oct 19, 2024
Merged
oakmac added a commit that referenced this issue Oct 19, 2024
@oakmac
GitHub Issue #103 - convert CRLF to LF line endings (#133)
d3fdb4a
@oakmac
Copy link
Owner Author

oakmac commented Oct 19, 2024 •
edited
Loading

The issue was related to CRLF line endings.

Fixed with PR-133

@oakmac oakmac closed this as completed Oct 19, 2024
@oakmac oakmac mentioned this issue Nov 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oakmac oakmac

Labels
bug Something isn't working help wanted Extra attention is needed v1 blocker Required for a v1.0.0 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oakmac