Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug with moving comma at the end of a line #104

Closed
oakmac opened this issue Oct 5, 2024 · 5 comments
Closed

bug with moving comma at the end of a line #104

oakmac opened this issue Oct 5, 2024 · 5 comments
Labels
bug Something isn't working v1 blocker Required for a v1.0.0 release

Comments

@oakmac
Copy link
Owner

oakmac commented Oct 5, 2024

Follow-up from Issue #102

This is incorrect behavior. The comma at the end of the line should not be moved.

@oakmac oakmac added bug Something isn't working v1 blocker Required for a v1.0.0 release labels Oct 5, 2024
@oakmac
Copy link
Owner Author

oakmac commented Oct 6, 2024

The current behavior is clearly buggy, but I wonder if Standard Clojure Style should remove commas at the end of lines entirely? Not sure of a case where it makes a lot of sense to keep a comma at the end of a line.

@oakmac
Copy link
Owner Author

oakmac commented Oct 7, 2024

I wonder if Standard Clojure Style should remove commas at the end of lines entirely?

trailing-whitespace

@oakmac
Copy link
Owner Author

oakmac commented Oct 7, 2024

I am leaning toward "Standard Clojure Style should treat eol commas as whitespace and remove them"

@NoahTheDuke
Copy link

Yes, and imo this aligns with the Clojure Style Guide. The "Optional Commas in Maps" section has a map with each entry on separate lines and no commas, and a map with both entries on one line and a comma between. Regardless of thoughts on the latter, the former indicates that commas shouldn't be at the end of the line.

@oakmac
Copy link
Owner Author

oakmac commented Oct 12, 2024

Fixed with PR-107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v1 blocker Required for a v1.0.0 release
Projects
None yet
Development

No branches or pull requests

2 participants