Lint: Perform nil check earlier

jamietanna · jamietanna · commit 38a6e18f9010 · 2023-07-31T11:15:03.000+01:00
diff --git a/email.go b/email.go
@@ -22,13 +22,17 @@ func (e Email) MarshalJSON() ([]byte, error) {
 }
 
 func (e *Email) UnmarshalJSON(data []byte) error {
+	if e == nil {
+		return nil
+	}
+
 	var s string
 	if err := json.Unmarshal(data, &s); err != nil {
 		return err
 	}
 
 	*e = Email(s)
-	if e != nil && !emailRegex.MatchString(s) {
+	if !emailRegex.MatchString(s) {
 		return ErrValidationEmail
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -22,13 +22,17 @@ func (e Email) MarshalJSON() ([]byte, error) {`
`22`	`22`	`}`
`23`	`23`
`24`	`24`	`func (e *Email) UnmarshalJSON(data []byte) error {`
	`25`	`+ if e == nil {`
	`26`	`+ return nil`
	`27`	`+ }`
	`28`	`+`
`25`	`29`	`var s string`
`26`	`30`	`if err := json.Unmarshal(data, &s); err != nil {`
`27`	`31`	`return err`
`28`	`32`	`}`
`29`	`33`
`30`	`34`	`*e = Email(s)`
`31`		`- if e != nil && !emailRegex.MatchString(s) {`
	`35`	`+ if !emailRegex.MatchString(s) {`
`32`	`36`	`return ErrValidationEmail`
`33`	`37`	`}`
`34`	`38`