[25.05] Build error Simgrid 3.34

[GuilloteauQ]

error: builder for '/nix/store/zyi89gkx2rqdv9f9dnqd5zjhgzs37m7b-simgrid-3.34.drv' failed with exit code 2;
       last 10 log lines:
       > /build/source/src/simgrid/module.cpp: In member function 'const simgrid::Module& simgrid::ModuleGroup::by_nam
e(const std::string&) const':
       > /build/source/src/simgrid/module.cpp:58:23: error: 'find_if' is not a member of 'std'; did you mean 'find'?
       >    58 |   if (auto pos = std::find_if(table_.begin(), table_.end(), [&name](const Module& item) { return item
.name_ == name; });
       >       |                       ^~~~~~~
       >       |                       find
       > make[2]: *** [CMakeFiles/simgrid.dir/build.make:331: CMakeFiles/simgrid.dir/src/simgrid/module.cpp.o] Error 1
       > make[2]: *** Waiting for unfinished jobs....
       > [ 30%] Building CXX object CMakeFiles/simgrid.dir/src/instr/instr_paje_events.cpp.o
       > make[1]: *** [CMakeFiles/Makefile2:2318: CMakeFiles/simgrid.dir/all] Error 2
       > make: *** [Makefile:166: all] Error 2
       For full logs, run 'nix log /nix/store/zyi89gkx2rqdv9f9dnqd5zjhgzs37m7b-simgrid-3.34.drv'.

[mpoquet]

remove simgrid 😝

[GuilloteauQ]

hmmmm batsim depends on simgrid-334

[GuilloteauQ]

nur-kapack/nur.nix

Line 38 in 5564064

batsim-420 = pkgs.callPackage ./pkgs/batsim/batsim420.nix { inherit redox debug; simgrid = simgrid-334light; intervalset = intervalsetlight; };

[GuilloteauQ]

diff --git a/src/simgrid/module.hpp b/src/simgrid/module.hpp
index 771fe09c92..375ae3ccc5 100644
--- a/src/simgrid/module.hpp
+++ b/src/simgrid/module.hpp
@@ -11,6 +11,7 @@
 #include <functional>
 #include <string>
 #include <vector>
+#include <algorithm>

 namespace simgrid {

this fixes it.

but now there is the following:

[ 94%] Building CXX object CMakeFiles/simgrid.dir/src/kernel/resource/models/network_ib.cpp.o
/home/doozer/nur-kapack-25.05/source/src/smpi/internals/smpi_shared.cpp: In function ‘std::vector<std::pair<long unsigned int, long unsi
gned int> > shift_and_frame_private_blocks(const std::vector<std::pair<long unsigned int, long unsigned int> >&, size_t, size_t)’:
/home/doozer/nur-kapack-25.05/source/src/smpi/internals/smpi_shared.cpp:397:42: error: ‘clamp’ is not a member of ‘std’
  397 |     auto new_block = std::make_pair(std::clamp(block_begin - offset, (size_t)0, buff_size),
      |                                          ^~~~~
/home/doozer/nur-kapack-25.05/source/src/smpi/internals/smpi_shared.cpp:398:42: error: ‘clamp’ is not a member of ‘std’
  398 |                                     std::clamp(block_end - offset, (size_t)0, buff_size));
      |                                          ^~~~~
make[2]: *** [CMakeFiles/simgrid.dir/build.make:3985: CMakeFiles/simgrid.dir/src/smpi/internals/smpi_shared.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:2318: CMakeFiles/simgrid.dir/all] Error 2
make: *** [Makefile:166: all] Error 2

the internet seems to say that using c++17 should be enough, but somehow it doesnt