-
Notifications
You must be signed in to change notification settings - Fork 28
breaking output limited to one line #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The idea is to include a summary in the PR and provide links to the report, as well as to the diff and changelog. The report can contain hundreds of lines. We initiated a discussion about this here. Please feel free to add your feedback. |
Thanks for the input. What's wrong with output having hundreds of lines? If I made that many breaking changes I would like to inspect those and text format in one place might be more convieniet at times (than annotations). And I've seen you already scoping it for that 1mb gh limit in all cases. Currently My use case is to present the breaking change inspection in the spoiler format in the GitHub comment. Annotations are nice but my use case is to present text format in a comment. This is similar to Spacelift integration commenting its terraform plans on PR. I understand you want to revamp and enchance how action would work in general though this is the problem I'm facing on the current action version. |
Thank you for the feedback. |
I've seen #35 but still, what is the purpose of that head?
Breaking output is different than diff or changelog. I would like to use that output in the PR comment. Could this be changed?
The text was updated successfully, but these errors were encountered: