Skip to content

Commit 61d8a74

Browse files
authored
test:tsc in CI (#1865)
1 parent 0f9e3af commit 61d8a74

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

.github/workflows/test.yml

+4-3
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ on:
77
branches: [main]
88

99
jobs:
10-
build:
10+
test:
1111
runs-on: ubuntu-latest
1212
steps:
1313
- uses: actions/checkout@v3
@@ -16,11 +16,12 @@ jobs:
1616
node-version: 16
1717
cache: 'yarn'
1818
- run: yarn --frozen-lockfile
19+
- run: yarn test:mocha
20+
- run: yarn test:tsc
1921
- run: |
2022
echo ::add-matcher::.github/eslint.json
2123
yarn run eslint src test --format=compact
22-
- run: yarn run prettier --check src test
23-
- run: yarn test:mocha
24+
- run: yarn test:prettier
2425
- run: yarn prepublishOnly
2526
- run: yarn docs:build
2627
- uses: actions/upload-artifact@v3

src/transforms/bin.d.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ export type BinYInputs<T> = Omit<T, "y"> & {y?: ChannelValueBinSpec} & BinOption
164164
export type BinInputs<T> = Omit<T, "x" | "y"> & {x?: ChannelValueBinSpec; y?: ChannelValueBinSpec} & BinOptions;
165165

166166
/** Output channels (and options) for the bin transform. */
167-
export type BinOutputs = ChannelReducers<BinReducer> & GroupOutputOptions<BinReducer> & BinOptions;
167+
export type BinOutputs = ChannelReducers<BinReducer> | (GroupOutputOptions<BinReducer> & BinOptions);
168168

169169
/**
170170
* Bins on the **x** channel; then subdivides bins on the first channel of

src/transforms/group.d.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ export interface GroupOutputOptions<T = Reducer> {
3939
}
4040

4141
/** Output channels (and options) for the group transform. */
42-
export type GroupOutputs = ChannelReducers & GroupOutputOptions;
42+
export type GroupOutputs = ChannelReducers | GroupOutputOptions;
4343

4444
/**
4545
* Groups on the first channel of **z**, **fill**, or **stroke**, if any, and

0 commit comments

Comments
 (0)