Skip to content

Commit f1a23a4

Browse files
committed
make Ast_mapper iterate over all locations inside Longident.t
These locations, which are new in 5.4, are sometimes traversed (e.g. Pexp_setfield) and sometimes not (e.g. Pexp_field). So clearly a bug. The fix is concretely: - change map_loc to map over both fields `{ loc; txt }` of `Location.loc` - propagate the change, ie change `map_loc` to `map_string_loc`, `map_string_opt_loc` or `map_loc_lid` depending on the type. All occurrences of the latter are bug fixes.
1 parent 3b8bf77 commit f1a23a4

File tree

1 file changed

+63
-65
lines changed

1 file changed

+63
-65
lines changed

0 commit comments

Comments
 (0)