response.headers is not iterable error

[yaronya]

Hi,

I'm using @octokit/rest as my GH rest client and I found a possible bug in

request.js/src/fetch-wrapper.ts

Line 50 in 92e7e1c

for (const keyAndValue of response.headers) {

where I use a fetch wrapper that return headers as a non-iterable object. In that case, @octokit/request throws an error saying response.headers is not iterable.

I'd expect the package to iterate the headers attribute only if it exists and is iterable...

[wolfy1339]

We switched to using the fetch API, which means that response.headers is a Headers instance, which is iterable.
That whole for loop can be simplified to use a simple Object.fromEntries()

Can you describe what the response.headers looks like for you? Is it a simple object?

[wolfy1339]

@yaronya Is this still an issue?

[Uzlopak]

I hit this issue also in #711

A plain object is not iterable. We could rewrite it, to accept plain objects, but on the other hand we want definetly set the condition to use a fetch implementation according to the spec.