Skip to content
This repository was archived by the owner on May 5, 2021. It is now read-only.

Commit 8264b72

Browse files
Zyntondmo-odoo
authored andcommitted
[FIX] Table: properly insert a table on pick a cell in tablepicker
This is a quick fix: we insert the table on mouseup instead of click. There is a deeper issue that made that close was triggered before click had a chance.
1 parent fced5e7 commit 8264b72

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

packages/plugin-table/src/TablePickerCellDomObjectRenderer.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ export class TablePickerCellDomObjectRenderer extends NodeRenderer<DomObject> {
111111
});
112112
}
113113
};
114-
const onClick = async (ev: Event): Promise<void> => {
114+
const onPickCell = async (ev: Event): Promise<void> => {
115115
const cell = ev.target as Element;
116116
await this.engine.editor.execCommand('insertTable', {
117117
rowCount: cell.getAttribute('data-rowCount'),
@@ -121,11 +121,11 @@ export class TablePickerCellDomObjectRenderer extends NodeRenderer<DomObject> {
121121

122122
domObject.attach = (el: HTMLTableCellElement): void => {
123123
el.addEventListener('mouseover', onMouseOver);
124-
el.addEventListener('click', onClick);
124+
el.addEventListener('mouseup', onPickCell);
125125
};
126126
domObject.detach = (el: HTMLTableCellElement): void => {
127127
el.removeEventListener('mouseover', onMouseOver);
128-
el.removeEventListener('click', onClick);
128+
el.removeEventListener('mouseup', onPickCell);
129129
};
130130
return domObject;
131131
}

0 commit comments

Comments
 (0)