[IMP] estate: Adding safeguard your code with unit tests

Author: coder-odoo

estate/models/estate_property.py

@@ -63,11 +63,13 @@ def _onchange_partner_id(self):
 
     def action_sold(self):
         for record in self:
-            if record.state != 'canceled':
-                record.state = 'sold'
-            else:
+            if record.state != 'offer_accepted':
+                error_msg = "You cannot sell a property that has not an accepted offer."
+                raise UserError(error_msg)
+            if record.state == 'canceled':
                 error_msg = "You cannot sell a canceled property."
                 raise UserError(error_msg)
+            record.state = 'sold'
         return True
 
     def action_cancel(self):

estate/models/estate_property_offer.py

@@ -55,11 +55,16 @@ def create(self, vals):
         if len(vals) == 0:
             return super().create(vals)
         property_id = vals[0].get('property_id')
+        property_record = self.env['estate.property'].browse(property_id)
+
+        if property_record.state in ['sold']:
+            error_msg = "You cannot make an offer on a property that is already sold."
+            raise ValidationError(error_msg)
+
         price = vals[0].get('price')
-        if property_id and price:
-            property_record = self.env['estate.property'].browse(property_id)
-            if property_record.best_price and price <= property_record.best_price:
-                error_msg = "The offer price should be higher than the best offer of the property."
-                raise ValidationError(error_msg)
-            property_record.state = 'offer_received'
+        if property_record.best_price and price <= property_record.best_price:
+            error_msg = "The offer price should be higher than the best offer of the property."
+            raise ValidationError(error_msg)
+
+        property_record.state = 'offer_received'
         return super().create(vals)

estate/tests/__init__.py

@@ -0,0 +1,3 @@
+# Part of Odoo. See LICENSE file for full copyright and licensing details.
+
+from . import test_estate

estate/tests/test_estate.py

@@ -0,0 +1,73 @@
+from odoo.exceptions import UserError
+from odoo.tests import Form, tagged
+from odoo.tests.common import TransactionCase
+
+
+@tagged('post_install', '-at_install')
+class EstateTestCase(TransactionCase):
+
+    @classmethod
+    def setUpClass(cls):
+        super().setUpClass()
+        cls.partner = cls.env['res.partner'].create({
+            'name': 'Test Partner',
+        })
+        cls.properties = cls.env['estate.property'].create([
+            {
+                'name': 'Property 1',
+                'expected_price': 100,
+            },
+            {
+                'name': 'Property 2',
+                'expected_price': 200,
+                'state': 'sold',
+            },
+            {
+                'name': 'Property 3',
+                'expected_price': 300,
+                'state': 'sold',
+            },
+        ])
+
+        cls.offer_partner = cls.env['res.partner'].create({
+            'name': 'Test Partner',
+        })
+
+    def test_cannot_create_offer_on_sold_property(self):
+        """Test that we cannot create an offer on a sold property."""
+        self.properties[0].write({'state': 'sold'})
+
+        with self.assertRaises(UserError):
+            self.env['estate.property.offer'].create([{
+                'price': 300,
+                'partner_id': self.offer_partner.id,
+                'property_id': self.properties[0].id,
+            }])
+
+    def test_cannot_sold_a_property_without_accepted_offer(self):
+        """Test that we cannot sold a property without an accepted offer."""
+
+        # Add an offer but not accept it
+        with self.assertRaises(UserError):
+            self.env['estate.property.offer'].create([{
+                'price': 300,
+                'partner_id': self.offer_partner.id,
+                'property_id': self.properties[1].id,
+            }])
+        # Sold without any offer
+        with self.assertRaises(UserError):
+            self.properties[2].action_sold()
+
+    def test_rest_garden_fields(self):
+        """Test that the garden fields are reset when the garden field is set to False."""
+        property_record = self.properties[0]
+
+        with Form(property_record) as property_form:
+            property_form.garden = True
+        self.assertEqual(property_record.garden_area, 10)
+        self.assertEqual(property_record.garden_orientation, 'north')
+
+        with Form(property_record) as property_form:
+            property_form.garden = False
+        self.assertEqual(property_record.garden_area, 0)
+        self.assertFalse(property_record.garden_orientation)