[IMP] Estate: Improve security and added actions in the properties form.\nSecurity:' prohibit: duplicate tags and negative prices'\n Actions: 'added visuals for properties state,linked status of offer to state of properties, added action to accept/refuse offer, added action to sold/cancel propertie

Author: josv-odoo

estate/models/estate_property.py

@@ -1,5 +1,5 @@
 from dateutil.relativedelta import relativedelta
-from odoo import api, fields, models
+from odoo import api, exceptions, fields, models
 
 
 class Estate(models.Model):
@@ -44,11 +44,28 @@ class Estate(models.Model):
         readonly=True,
     )
 
+    _sql_constraints = [
+        ('expected_price', 'CHECK(expected_price >= 0 )',
+         'A price should always be possitive'),
+         ('selling_price', 'CHECK(selling_price >= 0 )',
+         'A price should always be possitive')
+    ]
+
     @api.depends('living_area', 'garden_area')
     def _compute_total_area(self):
         for record in self:
             record.total_area = record.living_area + record.garden_area
 
+    @api.onchange('offer_ids')
+    def _onchange_status(self):
+        for record in self:
+            if record.state not in ['offer accepted', 'sold', 'cancelled']:
+                all_status = record.offer_ids.mapped('status')
+                new_state = 'new'
+                if all_status:
+                    new_state = 'offer received'
+            record.state = new_state          
+
     @api.depends('offer_ids')
     def _compute_best_offer(self):
         for record in self:
@@ -58,3 +75,25 @@ def _compute_best_offer(self):
             else:
                 record.best_offer = 0
 
+    @api.onchange('garden')
+    def _onchange_garden(self):
+        if self.garden:
+            self.garden_area = 10
+            self.garden_orientation = 'north'
+        else:
+            self.garden_area = 0
+            self.garden_orientation = ''
+
+    def action_property_sold(self):
+        for record in self:
+            if record.state == 'cancelled':
+                raise exceptions.UserError('property already cancelled')
+            record.state = 'sold'
+    
+    def action_property_cancelled(self):
+        for record in self:
+            if record.state == 'sold':
+                raise exceptions.UserError('property already sold')
+            record.state = 'cancelled'
+
+    

estate/models/estate_property_offer.py

@@ -1,5 +1,5 @@
 from dateutil.relativedelta import relativedelta
-from odoo import api, fields, models
+from odoo import api, exceptions, fields, models
 
 
 class EstateOffer(models.Model):
@@ -22,6 +22,11 @@ class EstateOffer(models.Model):
         default='pending',
     )
 
+    _sql_constraints = [
+        ('price', 'CHECK(price >= 0 )',
+         'A price should always be possitive')
+    ]
+
     @api.depends('create_date', 'validity')
     def _compute_date_deadline(self):
         for record in self:
@@ -34,3 +39,26 @@ def _compute_date_deadline(self):
     def _inverse_date(self):
         for record in self:
             record.validity = (record.date_deadline - fields.Date.today()).days
+
+    def action_accept_offer(self):
+        for record in self:
+            if record.property_id.state not in ['sold', 'cancelled']:
+                for offer in record.property_id.offer_ids:
+                    offer.status = 'refused'
+                record.status = 'accepted'
+                record.property_id.selling_price = record.price
+                record.property_id.state = 'offer accepted'
+            else:
+                raise exceptions.UserError('property already cancelled')
+        return True
+    
+    def action_refuse_offer(self):
+        for record in self:
+            if record.property_id.state not in ['sold', 'cancelled']:
+                if record.status == 'accepted':
+                    record.property_id.selling_price = 0
+                    record.property_id.state = 'offer received'
+            else:
+                raise exceptions.UserError('property already sold or cancelled')
+            record.status = 'refused'
+        return True

estate/models/estate_property_tag.py

@@ -6,3 +6,9 @@ class EstateTags(models.Model):
     _description = 'It allows to create a new property tag'
 
     name = fields.Char(required=True)
+
+    _sql_constraints = [
+        (
+            'unique_tag_by_estate_property', 'UNIQUE(name)',
+            'Only one name by tag')
+    ]

estate/view/estate_property_offer_views.xml

@@ -8,6 +8,8 @@
                 <field name="partner_id"/>
                 <field name="price"/>
                 <field name="status"/>
+                <button name="action_accept_offer" title="allows to accept an offer" type="object" class="fa fa-check"/>
+                <button name="action_refuse_offer" title="allows to refuse an offer" type="object" class="fa fa-times"/>
             </list>
         </field>
     </record>

estate/view/estate_property_views.xml

@@ -20,6 +20,11 @@
         <field name="model">estate.property</field>
         <field name="arch" type="xml">
             <form string="Estate">
+            <header>
+                <button name="action_property_sold" type="object" string="SOLD"/>
+                <button name="action_property_cancelled" type="object" string="CANCELLED"/>
+                <field name="state" widget="statusbar" statusbar_visible="new,offer received,offer accepted,sold" options="{'clickable': 1}"/>
+            </header>
                 <sheet>
                     <h1 class="oe_title">
                         <field name="name"/>
@@ -76,7 +81,7 @@
         <field name="arch" type="xml">
             <search string="Search Estates">
                 <field name="name"/>
-                <filter string="Available" name="available" domain="[('state', '!=', 'sold' ), ('state', '!=', 'cancelled'), ('state', '!=', 'offer_accepted')]"/>
+                <filter string="Available" name="available" domain="[('state', 'not in', ['sold','cancelled','offer_accepted'] )]"/>
                 <filter string="Garage" name="garage" domain="[('garage', '!=', True )]"/>
                 <group expand="True" string="Group By">
                         <filter string="Poscode" name="postcode" context="{'group_by':'postcode'}"/>