[IMP] estate: add business logic to CRUD and extend users view

Control the property CRUD operations by adding buisness logic,  blocking deletions and checking offer prices. We also updated the user profile so salespeople can see and manage all their properties in one place.

- Prevent deletion of properties unless state is 'New' or 'Cancelled' using the 'ondelete' decorator.
- Update property state to 'Offer Received' upon offer creation.
- Raise a validation error if a new offer price is lower than existing offers.
- Extend 'res.users' to include a list of properties assigned to the  salesperson via a One2many field with a domain for available properties.
- Inherit the users form view to display assigned properties in a new notebook page.

Author: karimgamaleldin

estate/__manifest__.py

@@ -12,6 +12,7 @@
         "views/estate_property_type_views.xml",
         "views/estate_property_tag_views.xml",
         "views/estate_property_offers_views.xml",
+        "views/estate_sales_person_views.xml",
         "views/estate_property_menus.xml",
         "views/estate_property_type_menus.xml",
         "views/estate_property_tag_menus.xml",

estate/models/__init__.py

@@ -2,3 +2,4 @@
 from . import estate_property_type
 from . import estate_property_tag
 from . import estate_property_offer
+from . import estate_sales_person

estate/models/estate_property.py

@@ -108,3 +108,15 @@ def action_set_cancel(self):
                 raise UserError("Sold properties cannot be canceled.")
             record.state = "canceled"
         return True
+
+    @api.ondelete(at_uninstall=False)
+    def _unlink_if_new_or_canceled(self):
+        for record in self:
+            if record.state not in ("new", "canceled"):
+                raise UserError("Only properties in 'new' or 'canceled' state can be deleted.")
+
+    def check_has_higher_offer(self, price):
+        for offer in self.offer_ids:
+            if float_compare(offer.price, price, precision_digits=2) > 0:
+                return True
+        return False

estate/models/estate_property_offer.py

@@ -60,3 +60,19 @@ def refuse_offer(self):
             offer.status = 'refused'
             if offer.property_id.state != 'offer_accepted':
                 offer.property_id.state = 'offer_received'
+
+    @api.model
+    def create(self, vals_list):
+        # Check that the offer price is higher than the current best offer for the property
+        for val in vals_list:
+            property_id = val.get('property_id')
+            has_higher_offer = self.env['estate.property'].browse(property_id).check_has_higher_offer(val.get('price', 0))
+            if has_higher_offer:
+                raise UserError('The offer price must be higher than the current best offer for the property.')
+        
+        # Create the offer
+        offer = super().create(vals_list)
+        if offer.property_id.state == 'new':
+            offer.property_id.state = 'offer_received'
+
+        return offer

estate/models/estate_sales_person.py

@@ -0,0 +1,7 @@
+from odoo import fields, models
+
+
+class EstateSalesPerson(models.Model):
+    _inherit = "res.users"
+
+    property_ids = fields.One2many("estate.property", "salesperson_id", string="Estate Properties", domain=[('state', 'in', ['new', 'offer_received'])])

estate/views/estate_sales_person_views.xml

@@ -0,0 +1,21 @@
+<?xml version='1.0' encoding='utf-8'?>
+<odoo>
+    <record id="view_estate_sales_person_form" model="ir.ui.view">
+        <field name="name">estate.salesperson.form</field>
+        <field name="model">res.users</field>
+        <field name="inherit_id" ref="base.view_users_form"/>
+        <field name="arch" type="xml">
+            <notebook position="inside">
+                <page string="Estate Properties">
+                    <field name="property_ids">
+                        <list string="Estate Properties">
+                            <field name="name"/>
+                            <field name="expected_price"/>
+                            <field name="state"/>
+                        </list>
+                    </field>
+                </page>
+            </notebook>
+        </field>
+    </record>
+</odoo>