[IMP] Estate: Improve security, added actions in the properties form, Improve the aesthetics. .

Security: prohibit: duplicate tags and negative prices

Actions:  added visuals for properties state, linked status of offer to state of properties, added action to accept/refuse offer, added action to sold/cancel properties.

Aesthetics : Added color to tags, hidden sold/cancelled/accepted/refused button (properties view), added status as a status bar on top (properties view), added properties (in properties type view)

Author: josv-odoo

estate/models/estate_property.py

@@ -1,10 +1,11 @@
 from dateutil.relativedelta import relativedelta
-from odoo import api, fields, models
+from odoo import api, exceptions, fields, models
 
 
 class Estate(models.Model):
     _name = 'estate.property'
     _description = 'It allows to manage your properties'
+    _order = 'id desc'
 
     name = fields.Char(required=True, default='Unknown')
     property_type_id = fields.Many2one('estate.property.type')
@@ -44,11 +45,26 @@ class Estate(models.Model):
         readonly=True,
     )
 
+    _sql_constraints = [
+        ('expected_price', 'CHECK(expected_price >= 0 )', 'A price should always be possitive'),
+        ('selling_price', 'CHECK(selling_price >= 0 )', 'A price should always be possitive'),
+    ]
+
     @api.depends('living_area', 'garden_area')
     def _compute_total_area(self):
         for record in self:
             record.total_area = record.living_area + record.garden_area
 
+    @api.onchange('offer_ids')
+    def _onchange_status(self):
+        for record in self:
+            if record.state not in ['offer accepted', 'sold', 'cancelled']:
+                all_status = record.offer_ids.mapped('status')
+                new_state = 'new'
+                if all_status:
+                    new_state = 'offer received'
+            record.state = new_state
+
     @api.depends('offer_ids')
     def _compute_best_offer(self):
         for record in self:
@@ -58,3 +74,23 @@ def _compute_best_offer(self):
             else:
                 record.best_offer = 0
 
+    @api.onchange('garden')
+    def _onchange_garden(self):
+        if self.garden:
+            self.garden_area = 10
+            self.garden_orientation = 'north'
+        else:
+            self.garden_area = 0
+            self.garden_orientation = ''
+
+    def action_property_sold(self):
+        for record in self:
+            if record.state == 'cancelled':
+                raise exceptions.UserError('property already cancelled')
+            record.state = 'sold'
+
+    def action_property_cancelled(self):
+        for record in self:
+            if record.state == 'sold':
+                raise exceptions.UserError('property already sold')
+            record.state = 'cancelled'

estate/models/estate_property_offer.py

@@ -1,18 +1,19 @@
 from dateutil.relativedelta import relativedelta
-from odoo import api, fields, models
+from odoo import api, exceptions, fields, models
 
 
 class EstateOffer(models.Model):
     _name = 'estate.property.offer'
     _description = 'It allows to create a new property offer'
+    _order = 'price desc'
 
     price = fields.Float(required=True)
     validity = fields.Integer()
     date_deadline = fields.Date(compute='_compute_date_deadline', inverse='_inverse_date')
     create_date = fields.Date(default=fields.Date.today(), required=True)
     partner_id = fields.Many2one('res.partner', string='Customer')
     property_id = fields.Many2one('estate.property', string='Property')
-    status= fields.Selection(
+    status = fields.Selection(
         string='State',
         selection=[
             ('pending', 'Pending'),
@@ -22,15 +23,39 @@ class EstateOffer(models.Model):
         default='pending',
     )
 
+    _sql_constraints = [('price', 'CHECK(price >= 0 )', 'A price should always be possitive')]
+
     @api.depends('create_date', 'validity')
     def _compute_date_deadline(self):
         for record in self:
             if record.create_date:
                 record.date_deadline = record.create_date + relativedelta(days=record.validity)
             else:
-                record.date_deadline = fields.Date.today()  + relativedelta(days=record.validity)
-
+                record.date_deadline = fields.Date.today() + relativedelta(days=record.validity)
 
     def _inverse_date(self):
         for record in self:
             record.validity = (record.date_deadline - fields.Date.today()).days
+
+    def action_accept_offer(self):
+        for record in self:
+            if record.property_id.state not in ['sold', 'cancelled']:
+                for offer in record.property_id.offer_ids:
+                    offer.status = 'refused'
+                record.status = 'accepted'
+                record.property_id.selling_price = record.price
+                record.property_id.state = 'offer accepted'
+            else:
+                raise exceptions.UserError('property already cancelled')
+        return True
+
+    def action_refuse_offer(self):
+        for record in self:
+            if record.property_id.state not in ['sold', 'cancelled']:
+                if record.status == 'accepted':
+                    record.property_id.selling_price = 0
+                    record.property_id.state = 'offer received'
+            else:
+                raise exceptions.UserError('property already sold or cancelled')
+            record.status = 'refused'
+        return True

estate/models/estate_property_tag.py

@@ -4,5 +4,9 @@
 class EstateTags(models.Model):
     _name = 'estate.property.tag'
     _description = 'It allows to create a new property tag'
+    _order = 'name desc'
 
     name = fields.Char(required=True)
+    color = fields.Integer(default=0)
+
+    _sql_constraints = [('unique_tag_by_estate_property', 'UNIQUE(name)', 'Only one name by tag')]

estate/models/estate_property_type.py

@@ -4,5 +4,8 @@
 class EstateType(models.Model):
     _name = 'estate.property.type'
     _description = 'It allows to create a new property type'
+    _order = 'sequence desc'
 
     name = fields.Char(required=True)
+    sequence = fields.Integer('Sequence', default=1, help='Used to order properties types. Lower is better.')
+    properties_ids = fields.One2many('estate.property', 'property_type_id')

estate/view/estate_property_offer_views.xml

@@ -8,6 +8,8 @@
                 <field name="partner_id"/>
                 <field name="price"/>
                 <field name="status"/>
+                <button name="action_accept_offer" title="allows to accept an offer" type="object" class="fa fa-check" invisible="status in ['accepted', 'refused']"/>
+                <button name="action_refuse_offer" title="allows to refuse an offer" type="object" class="fa fa-times" invisible="status in ['accepted', 'refused']"/>
             </list>
         </field>
     </record>

estate/view/estate_property_tag_views.xml

@@ -5,6 +5,7 @@
         <field name="arch" type="xml">
             <list string="Channel" editable="top">
                 <field name="name"/>
+                <field name="color" widget="color_picker"/>
             </list>
         </field>
     </record>

estate/view/estate_property_type_views.xml

@@ -3,7 +3,8 @@
         <field name="name">estate.type.main.list</field>
         <field name="model">estate.property.type</field>
         <field name="arch" type="xml">
-            <list string="Channel" editable="top">
+            <list string="Channel">
+                <field name="sequence" widget="handle"/>
                 <field name="name"/>
             </list>
         </field>
@@ -12,6 +13,31 @@
     <record id='estate_property_type_action' model='ir.actions.act_window'>
         <field name='name'>property_type_action</field>
         <field name='res_model'>estate.property.type</field>
-        <field name='view_mode'>list</field>
+        <field name='view_mode'>list,form</field>
+    </record>
+
+        <record id="estate_property_type_view_form" model="ir.ui.view">
+        <field name="name">estate.property.type.form</field>
+        <field name="model">estate.property.type</field>
+        <field name="arch" type="xml">
+            <form string="Estate Offer">
+                <sheet>
+                    <h1 class="oe_title">
+                        <field name="name"/>
+                    </h1>
+                    <notebook>
+                        <page string="Properties">
+                            <field name="properties_ids">
+                                <list>
+                                    <field name="name"/>
+                                    <field name="expected_price"/>
+                                    <field name="state"/>
+                                </list>
+                            </field>
+                        </page>
+                    </notebook>
+                </sheet>
+            </form>
+        </field>
     </record>
 </odoo>

estate/view/estate_property_views.xml

@@ -20,11 +20,16 @@
         <field name="model">estate.property</field>
         <field name="arch" type="xml">
             <form string="Estate">
+            <header>
+                <button name="action_property_sold" type="object" string="SOLD" invisible="state in ['sold', 'cancelled']"/>
+                <button name="action_property_cancelled" type="object" string="CANCELLED" invisible="state in ['sold', 'cancelled']"/>
+                <field name="state" widget="statusbar" statusbar_visible="new,offer received,offer accepted,sold" options="{'clickable': 1}"/>
+            </header>
                 <sheet>
                     <h1 class="oe_title">
                         <field name="name"/>
                     </h1>
-                    <field name="tag_ids"  widget="many2many_tags" class="mb16"/>
+                    <field name="tag_ids"  widget="many2many_tags" class="mb16" options="{'color_field': 'color'}"/>
                     <div class="row">
                         <div class="col-6">
                             <group>
@@ -48,8 +53,8 @@
                                 <field name="facades"/>
                                 <field name="garage"/>
                                 <field name="garden"/>
-                                <field name="garden_orientation"/>
-                                <field name="garden_area"/>
+                                <field name="garden_orientation" invisible="not garden"/>
+                                <field name="garden_area" invisible="not garden"/>
                                 <field name="living_area"/>
                                 <field name="total_area"/>
                                 <field name="property_type_id"/>
@@ -62,7 +67,7 @@
                             </group>
                         </page>
                         <page string="Offers">
-                            <field name="offer_ids"/>
+                            <field name="offer_ids" readonly="state not in ['new', 'offer received']"/>
                         </page>
                     </notebook>
                 </sheet>
@@ -76,7 +81,7 @@
         <field name="arch" type="xml">
             <search string="Search Estates">
                 <field name="name"/>
-                <filter string="Available" name="available" domain="[('state', '!=', 'sold' ), ('state', '!=', 'cancelled'), ('state', '!=', 'offer_accepted')]"/>
+                <filter string="Available" name="available" domain="[('state', 'not in', ['sold','cancelled','offer_accepted'] )]"/>
                 <filter string="Garage" name="garage" domain="[('garage', '!=', True )]"/>
                 <group expand="True" string="Group By">
                         <filter string="Poscode" name="postcode" context="{'group_by':'postcode'}"/>