Skip to content

Commit fe284ec

Browse files
committed
[IMP] report: warn when writing long message to migration report
tbg-1840 Making it easier to prevent and/or identify problematic (i.e. overly long) message insertions. Part-of: #216 Signed-off-by: Christophe Simonis (chs) <[email protected]>
1 parent 71bd87f commit fe284ec

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

src/util/report.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,11 @@ def add_to_migration_reports(message, category="Other", format="text"):
105105
else:
106106
raw = True
107107
migration_reports.setdefault(category, []).append((message, raw))
108+
migration_reports_length = sum(len(msg) for reps in migration_reports.values() for msg, _ in reps) + sum(
109+
map(len, migration_reports)
110+
)
111+
if migration_reports_length > 1000000:
112+
_logger.warning("Upgrade report is growing suspiciously long: %s characters so far.", migration_reports_length)
108113

109114

110115
def announce_release_note(cr):

0 commit comments

Comments
 (0)