False Positive for http://das-küchengeflüster.de/feed

[tschellenbach]

isWebUri('http://das-küchengeflüster.de/feed') returns undefined.

[floppypanda]

@tschellenbach I doubt that @ogt will merge in this pull request as there have been no commits on this repository since 2015, but I hope that the changes on my fork will prove useful to you in some way.

[adrienv1520]

Hi @tschellenbach and @floppypanda,

I was facing the same issues with valid-url but also validator so I decided to build a module as reliable as possible strictly based on RFC-3986: https://github.com/adrienv1520/node-uri

The main features of this project are:

• parse any URI (URNs, URLs, URIs with IDNs support, etc.);
• get the safe Punycode ASCII or Unicode serialization of a domain;
• check an URI, HTTP/HTTPS/Sitemap URL, IP, domain is valid with clear checking errors;
• encode/decode an URI, HTTP/HTTPS/Sitemap URL.

I hope it could help you guys.

[ogt]

I doubt that @ogt <https://github.com/ogt> will merge in this pull

request as there have been no commits on this repository since 2015, but I hope that the changes on my fork will prove useful to you in some way. Just saw this 2 yr old "shaming" I just merged the 2 2-yr old merge requests. I will try to behave better in the future odysseas

…

On Sat, Oct 17, 2020 at 9:51 AM Adrien Valcke ***@***.***> wrote: Hi @tschellenbach <https://github.com/tschellenbach> and @floppypanda <https://github.com/floppypanda>, I was facing the same issues with valid-url but also validator so I decided to build a module as reliable as possible strictly based on RFC-3986: https://github.com/adrienv1520/node-uri The main features of this project are: - parse any URI (URNs, URLs, URIs with IDNs support, etc.); - get the safe Punycode ASCII or Unicode serialization of a domain; - check an URI, HTTP/HTTPS/Sitemap URL, IP, domain is valid with clear checking errors; - encode/decode an URI, HTTP/HTTPS/Sitemap URL. I hope it could help you guys. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#20 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABFOS5Q6INKGAWGRW6FZPTSLHDPVANCNFSM4FEUHUBQ> .

[adrienv1520]

Hi @ogt,

Thanks for taking time to merge these PRs. I hope it will fix some of the issues even though applying RFC-3986 is far more complex than it seems to valid an URL based on this standard.

You need to watch for:

• any invalid characters that should be percent-encoded;
• any percent-encoding that is not valid;
• scheme, userinfo, path, query and fragment have each specific characters allowed;
• authority is composed of a host that also has a specific form (IP, domain name of FQDN or IDN, max length for domain label and the whole domain name, etc.) and a port that should be a number between 0 - 65535.

That's why I've been developing node-uri from scratch.

Thanks again.

Adrien

[ogt]

Got it. Makes sense, thank you, odysseas

…

On Wed, Oct 21, 2020 at 10:28 AM Adrien Valcke ***@***.***> wrote: Hi @ogt <https://github.com/ogt>, Thanks for taking time to merge these PRs. I hope it will fix some of the issues even though applying RFC-3986 is far more complex than it seems to valid an URL based on this standard. You need to watch for: - any invalid characters that should be percent-encoded; - any percent-encoding that is not valid; - scheme, userinfo, path, query and fragment have each specific characters allowed; - authority is composed of a host that also has a specific form (IP, domain name of FQDN or IDN, max length for domain label and the whole label, etc.) and a port that should be a number between 0 - 65535. That's why I've been developing node-uri from scratch. Thanks again. Adrien — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#20 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABFOSZGNG3UBSZVEGOS5BLSL4K2BANCNFSM4FEUHUBQ> .