Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_creation_date and _last_modified have inconsistent implementations #12

Open
lwcolton opened this issue Jan 18, 2015 · 0 comments
Open

Comments

@lwcolton
Copy link

_creation_date and _last_modified will have different values depending on which plugin you are using.

In peartree:

json_payload[label]['_last_modified'] = datetime.now().isoformat().split(".")[0]

In botostore:

params['_creation_time'] = str(datetime.utcnow())

Two problems:

  • We are using datetimes and not epoch timestamps
  • We are applying timezone offsets in some plugins but not others

Proposed solution:
Add _created and _modified which will both be epoch timestamps. Existing plugins may continue to implement _last_modified and _creation_time for backwards compatibility, but they will be deprecated and phased out.

Please advise if this is acceptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant