Skip to content

Commit 6e8b37f

Browse files
ronald-cron-armoliviermartin
authored andcommitted
ArmPlatformPkg: PCI emulation - Define a vendor and device id
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ronald Cron <[email protected]> Reviewed-by: Olivier Martin <[email protected]> git-svn-id: https://svn.code.sf.net/p/edk2/code/trunk/edk2@16587 6f19259b-4bc3-4df7-8a09-765794883524
1 parent ad7e31b commit 6e8b37f

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

ArmPlatformPkg/ArmJunoPkg/Drivers/ArmJunoDxe/PciEmulation.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -547,8 +547,8 @@ PciInstallDevice (
547547
//
548548
// Configure PCI config space: OHCI + EHCI
549549
//
550-
Private->ConfigSpace->Hdr.VendorId = 0x3530; //TODO: Define one
551-
Private->ConfigSpace->Hdr.DeviceId = 0x3530; //TODO: Define one
550+
Private->ConfigSpace->Hdr.VendorId = 0xFFFF; // Invalid vendor Id as it is not an actual device.
551+
Private->ConfigSpace->Hdr.DeviceId = 0x0000; // Not relevant as the vendor id is not valid.
552552
Private->ConfigSpace->Hdr.ClassCode[0] = ClassCode1;
553553
Private->ConfigSpace->Hdr.ClassCode[1] = ClassCode2;
554554
Private->ConfigSpace->Hdr.ClassCode[2] = ClassCode3;

Omap35xxPkg/PciEmulation/PciEmulation.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -604,8 +604,8 @@ PciEmulationEntryPoint (
604604
}
605605

606606
// Configure PCI config space
607-
Private->ConfigSpace->Hdr.VendorId = 0x3530;
608-
Private->ConfigSpace->Hdr.DeviceId = 0x3530;
607+
Private->ConfigSpace->Hdr.VendorId = 0xFFFF; // Invalid vendor Id as it is not an actual device.
608+
Private->ConfigSpace->Hdr.DeviceId = 0x0000; // Not relevant as the vendor id is not valid.
609609
Private->ConfigSpace->Hdr.ClassCode[0] = 0x20;
610610
Private->ConfigSpace->Hdr.ClassCode[1] = 0x03;
611611
Private->ConfigSpace->Hdr.ClassCode[2] = 0x0C;

0 commit comments

Comments
 (0)