✅ More tests

Author: pboling

spec/omniauth/strategies/ldap_spec.rb

@@ -347,7 +347,7 @@ def make_env(path = "/auth/ldap", props = {})
         it "escapes special characters in username when building filter" do
           allow(@adaptor).to receive(:filter).and_return("uid=%{username}")
           # '(' => \28 and ')' => \29 per RFC 4515 escaping
-          expect(Net::LDAP::Filter).to receive(:construct).with("uid=al\\28ice\\29")
+          expect(Net::LDAP::Filter).to receive(:construct).with('uid=al\28ice\29')
           post("/auth/ldap/callback", {username: "al(ice)", password: "secret"})
         end
 
@@ -444,8 +444,8 @@ def make_env(path = "/auth/ldap", props = {})
 
         it 'should map user info according to customized mapping' do
           post('/auth/ldap/callback', {:username => 'ping', :password => 'password'})
-          auth_hash.info.phone.should == '444-444-4444'
-          auth_hash.info.mobile.should == '444-444-4444'
+          expect(auth_hash.info.phone).to eq '444-444-4444'
+          expect(auth_hash.info.mobile).to eq '444-444-4444'
         end
       end
     end
@@ -604,7 +604,7 @@ def connection_returning(entry)
         connection: connection_returning(entry),
         filter: "uid=%{username}",
       )
-      expect(Net::LDAP::Filter).to receive(:construct).with("uid=al\\28ice\\29").and_call_original
+      expect(Net::LDAP::Filter).to receive(:construct).with('uid=al\28ice\29').and_call_original
 
       post "/auth/ldap/callback", nil, {"REMOTE_USER" => "al(ice)"}
       expect(last_response).not_to be_redirect
@@ -632,5 +632,41 @@ def connection_returning(entry)
       post "/auth/ldap/callback", nil, {"REMOTE_USER" => "[email protected]"}
       expect(last_response).not_to be_redirect
     end
+
+    context "with custom mapping option" do
+      let(:app) do
+        Rack::Builder.new do
+          use OmniAuth::Test::PhonySession
+          use MyHeaderProvider,
+            name: "ldap",
+            title: "Header LDAP",
+            host: "ldap.example.com",
+            base: "dc=example,dc=com",
+            uid: "uid",
+            header_auth: true,
+            header_name: "REMOTE_USER",
+            name_proc: proc { |n| n },
+            mapping: { "phone" => "mobile" }
+          run lambda { |env| [404, {"Content-Type" => "text/plain"}, [env.key?("omniauth.auth").to_s]] }
+        end.to_app
+      end
+
+      it "applies the custom mapping in header SSO path" do
+        entry = Net::LDAP::Entry.from_single_ldif_string(%{dn: cn=bob, dc=example, dc=com
+uid: bob
+mobile: 444-444-4444
+telephonenumber: 555-555-5555
+})
+        allow(@adaptor).to receive(:connection).and_return(connection_returning(entry))
+
+        post "/auth/ldap/callback", nil, {"REMOTE_USER" => "bob"}
+        expect(last_response).not_to be_redirect
+        auth = last_request.env["omniauth.auth"]
+        # phone should come from mobile due to custom mapping override
+        expect(auth.info.phone).to eq "444-444-4444"
+        # mobile remains available as well
+        expect(auth.info.mobile).to eq "444-444-4444"
+      end
+    end
   end
 end