Skip to content

Commit d733454

Browse files
committed
Merge pull request #74 from isaacsanders/fix-including-bug
Fixes a bug where the included hook isn't run.
2 parents 64a4f97 + 43c84c8 commit d733454

File tree

2 files changed

+13
-0
lines changed

2 files changed

+13
-0
lines changed

lib/omniauth/strategies/oauth2.rb

+4
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,10 @@ module Strategies
1414
class OAuth2
1515
include OmniAuth::Strategy
1616

17+
def self.inherited(subclass)
18+
OmniAuth::Strategy.included(subclass)
19+
end
20+
1721
args [:client_id, :client_secret]
1822

1923
option :client_id, nil

spec/omniauth/strategies/oauth2_spec.rb

+9
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,15 @@ def app
1616
OmniAuth.config.test_mode = false
1717
end
1818

19+
describe "Subclassing Behavior" do
20+
subject { fresh_strategy }
21+
22+
it "performs the OmniAuth::Strategy included hook" do
23+
expect(OmniAuth.strategies).to include(OmniAuth::Strategies::OAuth2)
24+
expect(OmniAuth.strategies).to include(subject)
25+
end
26+
end
27+
1928
describe "#client" do
2029
subject { fresh_strategy }
2130

0 commit comments

Comments
 (0)