Resolve Issues With Test We Contract

[earth2travis]

Deployed TestWe.sol ERC-721 contract and TestWe.t.sol to Base Sepolia in #1

Used the the Solidity Wizard to create a starter template to work from: #1 (comment)

Made a few minor changes to the starter template: #1 (comment)

Got the tests passing and the contract deployed and verified: https://sepolia.basescan.org/address/0x5324735Aa67FaE868C90795CBbAD9F78700664dD

Minted two test NFTs:

• https://testnets.opensea.io/assets/base-sepolia/0x5324735aa67fae868c90795cbbad9f78700664dd/0
• https://testnets.opensea.io/assets/base-sepolia/0x5324735aa67fae868c90795cbbad9f78700664dd/1

For the first one I used the metadata in the uri (string):

ipfs://QmYNsRQWtiC37rkf66gxPSvu4FRtFWp2kgMU9z2yi1HfPi (shall-we.json)

For the second on I used the image in the uri (string):

ipfs://QmSouB7L7mVsonRtp168ybpFkQThwmtZLeanjJ6uynY1bs (shall-we.png)

Of course the biggest issue is the images are not showing.

But here is a list of other things I would like to figure out:

Issues

• No image (Should I have used the image uri instead of metadata when calling safeMint?)
• It started with #0 (Should probably start with #1.)
• No collection description yet
• No traits from the metadata
• Do we need to have the uri for safeMint
• Wallet transaction says +Unknown NFT onchain-warfare/mint#0
• No mint price
• No beneficiary
• Remove anything that is not necessary
• Add anything that is missing from https://github.com/skuhlmann/warframes-contract/blob/master/contracts/nfts/WarGamesOne.sol

[earth2travis]

Notes from Call With Dekan

Underscores are a naming convention for private variables.

Base URI should be the metadata.

Being able to input the URI when you Write Contract is good for testing. But you will probably want to specify it in your production contracts. It is typically restricted to a market contract. Or a server that has the private key and returns the URI. He used base 64 encoded metadata to avoid having to store the data. Browsers understand the encoded file.

If you got to Read Contract and input your token IDs into the tokenURI function:

• 0: "ipfs://QmYNsRQWtiC37rkf66gxPSvu4FRtFWp2kgMU9z2yi1HfPiipfs://QmYNsRQWtiC37rkf66gxPSvu4FRtFWp2kgMU9z2yi1HfPi"
• 1: "ipfs://QmYNsRQWtiC37rkf66gxPSvu4FRtFWp2kgMU9z2yi1HfPiipfs://QmSouB7L7mVsonRtp168ybpFkQThwmtZLeanjJ6uynY1bs"

You can see that it is concatenating two IPFS addresses. The second address is the one you are putting in when you Write Contract. The first one was when you input the metadata (shall-we.json) the second one was when you input the image (shall-we.png).

Need to figure out how to only return one address.

In the function tokenURI "super" calls the tokenURI function from the parent contracts. This overrides and integrates the functionality from ERC721.sol and ERC721URIStorage.sol.

In the ERC721.sol you import this is the tokenURI function:

    /**
     * @dev See {IERC721Metadata-tokenURI}.
     */
    function tokenURI(uint256 tokenId) public view virtual returns (string memory) {
        _requireOwned(tokenId);

        string memory baseURI = _baseURI();
        return bytes(baseURI).length > 0 ? string.concat(baseURI, tokenId.toString()) : "";
    }

Maybe remove token URI storage from SafeMint. Remove the "super" from tokenURI

change:

    function tokenURI(uint256 tokenId)
        public
        view
        override(ERC721, ERC721URIStorage)
        returns (string memory)
    {
        return super.tokenURI(tokenId);
    }

to:

    function tokenURI(uint256 tokenId)
        public
        view
        override(ERC721, ERC721URIStorage)
        returns (string memory)
    {
        require(ownerOf(tokenId)!=address(0), "No Owner");
        return _baseURI();
    }

[earth2travis]

In the tokenURI function:

change:

return super.tokenURI(tokenId);

to:

return ERC721URIStorage.tokenURI(tokenId);

To ensures that only the URL provided to ERC721URIStorage's tokenURI function is called to prevent concatenation issues.

Is the the URI from that is input with Write Contract? (Don't think that is the one we want)

[earth2travis]

Let's give it a shot:

forge test

[⠢] Compiling...
No files changed, compilation skipped

Ran 1 test for test/TestWe.t.sol:TestWeTest
[PASS] testSafeMint() (gas: 192663)
Suite result: ok. 1 passed; 0 failed; 0 skipped; finished in 20.41ms (3.34ms CPU time)

Ran 1 test suite in 561.66ms (20.41ms CPU time): 1 tests passed, 0 failed, 0 skipped (1 total tests)

Deploy

forge create src/TestWe.sol:TestWe \
--rpc-url https://sepolia.base.org \
--private-key <PRIVATE_KEY>

[⠒] Compiling...
No files changed, compilation skipped
Deployer: 0x1a75971C77957d26f8D81C29f9A2093f5F989Dd5
Deployed to: 0xfB91f1e21f06cb79889359bD5840a4737495B839
Transaction hash: 0x6df4adb0b08b13a55ab6052863b9765b891712d43bc8df03d168af0cd0d6875c

https://sepolia.basescan.org/address/0xfB91f1e21f06cb79889359bD5840a4737495B839

Verify

forge verify-contract 0xfB91f1e21f06cb79889359bD5840a4737495B839  \
TestWe \
--etherscan-api-key <ETHERSCAN_API_KEY> \
--verifier-url https://api-sepolia.basescan.org/api \
--watch

Start verifying contract `0xfB91f1e21f06cb79889359bD5840a4737495B839` deployed on mainnet

Submitting verification for [src/TestWe.sol:TestWe] 0xfB91f1e21f06cb79889359bD5840a4737495B839.
Submitted contract for verification:
        Response: `OK`
        GUID: `srgqa67t48uxdbhjshmd23xyezhxcexjfr6dfhkmiuqec3qumx`
        URL: https://etherscan.io/address/0xfb91f1e21f06cb79889359bd5840a4737495b839
Contract verification status:
Response: `NOTOK`
Details: `Pending in queue`
Contract verification status:
Response: `OK`
Details: `Pass - Verified`
Contract successfully verified

https://sepolia.basescan.org/address/0xfB91f1e21f06cb79889359bD5840a4737495B839

[earth2travis]

https://sepolia.basescan.org/address/0xfB91f1e21f06cb79889359bD5840a4737495B839

Add the image to uri (string): ipfs://QmcaHejVG4YvtqKABvhNcAEh14KiE5Fv4yYMwxR1aQ7Wdi

Transaction

https://testnets.opensea.io/assets/base-sepolia/0xfb91f1e21f06cb79889359bd5840a4737495b839/0

Still concatenated:

Gonna change:

return ERC721URIStorage.tokenURI(tokenId);

back to:

return super.tokenURI(tokenId);

And experiment with Dekan's idea

[earth2travis]

Maybe remove token URI storage from SafeMint. Remove the "super" from tokenURI

change:

    function tokenURI(uint256 tokenId)
        public
        view
        override(ERC721, ERC721URIStorage)
        returns (string memory)
    {
        return super.tokenURI(tokenId);
    }

to:

    function tokenURI(uint256 tokenId)
        public
        view
        override(ERC721, ERC721URIStorage)
        returns (string memory)
    {
        _requireOwned(tokenId);
        return _baseURI();
    }

---

change:

    function safeMint(address to, string memory uri) public {
        uint256 tokenId = _nextTokenId++;
        _safeMint(to, tokenId);
        _setTokenURI(tokenId, uri);
    }

to:

    function safeMint(address to) public {
        uint256 tokenId = _nextTokenId++;
        _safeMint(to, tokenId);
    }

[earth2travis]

Deployer: 0x1a75971C77957d26f8D81C29f9A2093f5F989Dd5
Deployed to: 0xDf3990Ac93658e7f3aC341EF7c3549a637B995Eb
Transaction hash: 0x78c6bc2780a9a0c572d22f129c5492bfb15a598e11b29cb6d0b7686f5a2cd69b

Contract verification status:
Response: `OK`
Details: `Pass - Verified`
Contract successfully verified

https://sepolia.basescan.org/address/0xDf3990Ac93658e7f3aC341EF7c3549a637B995Eb

[earth2travis]

Transaction

https://testnets.opensea.io/assets/base-sepolia/0xdf3990ac93658e7f3ac341ef7c3549a637b995eb/0

[earth2travis]

Add function allowing updates to the tokenURI so we can get metadata dialed in:

   function updateTokenURI(uint256 tokenId, string memory uri) public onlyOwner {
        _setTokenURI(tokenId, uri);
    }

Should make a decision about whether it is desirable to keep in?

Updated metadata and image

Deployer: 0x1a75971C77957d26f8D81C29f9A2093f5F989Dd5
Deployed to: 0x9ef73e41F3226e0C6795F0aE8D960a99138Ba294
Transaction hash: 0x8d02fdca81b0507ee1ed819a12023d3be0e0e3320714b59dc5ee630a5fcd2c54

Contract verification status:
Response: `OK`
Details: `Pass - Verified`
Contract successfully verified

https://sepolia.basescan.org/address/0x9ef73e41f3226e0c6795f0ae8d960a99138ba294

[earth2travis]

Transaction

https://testnets.opensea.io/assets/base-sepolia/0x9ef73e41f3226e0c6795f0ae8d960a99138ba294/0

So the metadata seems correct. Don't know why the image is not showing.

{
  "description": "Inaugural drop of WarFrames. A call to arms. A herald. A harbinger of onchain warfare. A key to future engagements. The question is simple. The answer lies with you.",
  "external_url": "https://warframes.wtf/",
  "image": "ipfs://QmZyxJKxjGsMYrvFQWgH8B2sFBZkGMT97T1GS4Yz5iwS91",
  "name": "Shall we play a frame?",
  "attributes": [
    {
      "trait_type": "Access",
      "value": "Restricted"
    },
    {
      "trait_type": "Engagement",
      "value": "Solo"
    },
    {
      "trait_type": "Mode",
      "value": "Real"
    }
  ]
}

Wonder what we could do to have some interesting mechanics and rarity built into the traits?

[earth2travis]

Maybe the image is not displaying is related to that function we added allowing updates to the tokenURI:

remove:

   function updateTokenURI(uint256 tokenId, string memory uri) public onlyOwner {
        _setTokenURI(tokenId, uri);
    }

[⠒] Compiling...
[⠰] Compiling 2 files with Solc 0.8.23
[⠒] Solc 0.8.23 finished in 4.43s
Compiler run successful!

Ran 1 test for test/TestWe.t.sol:TestWeTest
[PASS] testSafeMint() (gas: 120922)
Suite result: ok. 1 passed; 0 failed; 0 skipped; finished in 30.73ms (3.09ms CPU time)

Ran 1 test suite in 372.28ms (30.73ms CPU time): 1 tests passed, 0 failed, 0 skipped (1 total tests)

Deployer: 0x1a75971C77957d26f8D81C29f9A2093f5F989Dd5
Deployed to: 0x09B2dc2236dDe2BbD0E543d651Fd5C3d1C1c2A81
Transaction hash: 0x8e29a84a031b0aacb605313bd35f530c3885cd84b75b3502e12d8e2bfa05e319

Contract verification status:
Response: `OK`
Details: `Pass - Verified`
Contract successfully verified

https://sepolia.basescan.org/address/0x09b2dc2236dde2bbd0e543d651fd5c3d1c1c2a81

[earth2travis]

https://sepolia.basescan.org/address/0x09b2dc2236dde2bbd0e543d651fd5c3d1c1c2a81

Transaction

https://testnets.opensea.io/assets/base-sepolia/0x09b2dc2236dde2bbd0e543d651fd5c3d1c1c2a81/0

[earth2travis]

Test Moar

Deploy

Deployer: 0x1a75971C77957d26f8D81C29f9A2093f5F989Dd5
Deployed to: 0x6a11e59A95a649934146107C917C81a17e72347A
Transaction hash: 0x86fb24f01d9d4372f387754be128b58240f30ebe11dceb44fd45947718eb2b47

Verify

Contract verification status:
Response: `OK`
Details: `Pass - Verified`
Contract successfully verified

Contract

https://sepolia.basescan.org/address/0x6a11e59a95a649934146107c917c81a17e72347a

Mint

https://sepolia.basescan.org/tx/0xcf735d79349ec3c46ca39b39e84d95c562dd959ea2364d447d3a7044a535379d

For some reason tokenURI is returning an IPFS has with a zero on the end:

ipfs://QmS3o2PYn5RA3kmDW1nXicrXeX8VmgzMaEnYoy9wwEHtAQ0

[earth2travis]

Test Moar Two

Deploy

Deployer: 0x1a75971C77957d26f8D81C29f9A2093f5F989Dd5
Deployed to: 0x42F8196D40C7A7fd5dE8C667E7D22743404b5C17
Transaction hash: 0x9adc69fd5c3b426d7e82e8d133e9e0f71fe9c215142452c3e47e1a5b1a089d38

Verify

Start verifying contract `0x42F8196D40C7A7fd5dE8C667E7D22743404b5C17` deployed on mainnet

Contract [src/TestMoar.sol:TestMoar] "0x42F8196D40C7A7fd5dE8C667E7D22743404b5C17" is already verified. Skipping verification.

Contract

https://sepolia.basescan.org/address/0x42F8196D40C7A7fd5dE8C667E7D22743404b5C17

Mint

https://sepolia.basescan.org/tx/0x7f225862e97a469ec7140f8a9b7c350dc3db01c70f6ae50eea2faafab80587d5

OpenSea

https://testnets.opensea.io/assets/base-sepolia/0x42f8196d40c7a7fd5de8c667e7d22743404b5c17/0

[earth2travis]

added:

    function tokenURI(uint256 tokenId) public view override(ERC721) returns (string memory) {
        _requireOwned(tokenId);
        return _baseURI();
    }

Test Moar Three

Deploy

Deployer: 0x1a75971C77957d26f8D81C29f9A2093f5F989Dd5
Deployed to: 0x1bcB2C1055734c45249e40476E422473619c27D4
Transaction hash: 0x1e4a692d0629288fd740911ea42508cf9837e4696524fd73d64f401189f0a89b

Verify

Contract verification status:
Response: `OK`
Details: `Pass - Verified`
Contract successfully verified

Contract

https://sepolia.basescan.org/address/0x1bcB2C1055734c45249e40476E422473619c27D4

Mint

https://sepolia.basescan.org/tx/0x2a7331e4b6e738f8e643f81a1594e57ba164d813344f178e78657000678e5cf3

OpenSea

https://testnets.opensea.io/assets/base-sepolia/0x42f8196d40c7a7fd5de8c667e7d22743404b5c17/0