Skip to content

Commit e89f3af

Browse files
authored
Merge pull request #1067 from lukaszstolarczuk/fix-bench-cache
Fix bench cache restore
2 parents 9377fd0 + 647214e commit e89f3af

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

.github/workflows/reusable_benchmarks.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -159,5 +159,5 @@ jobs:
159159
if: ${{ always() && inputs.upload_report }}
160160
uses: actions/cache/save@1bd1e32a3bdc45362d1e726936510720a7c30a57 # v4.2.0
161161
with:
162-
path: ${{env.BUILD_DIR}}/benchmark_results.html
162+
path: umf-repo/build/benchmark_results.html
163163
key: benchmark-results-${{ github.run_id }}

.github/workflows/reusable_docs_build.yml

+4-5
Original file line numberDiff line numberDiff line change
@@ -45,20 +45,19 @@ jobs:
4545
-DUMF_DISABLE_HWLOC=ON
4646
cmake --build build --target docs
4747
48-
- name: Download benchmark HTML before uploading with documentation on GitHub pages
49-
# If the benchmark results are meant to be uploaded on GH pages
48+
# If we upload HTML docs, we want to include benchmark results as well
49+
- name: Download benchmark HTML before uploading docs
5050
if: ${{ inputs.upload == true }}
5151
id: download-bench-html
5252
uses: actions/cache/restore@1bd1e32a3bdc45362d1e726936510720a7c30a57 # v4.2.0
5353
with:
54-
path: ${{github.workspace}}/build/benchmark_results.html
54+
path: umf-repo/build/benchmark_results.html
5555
key: benchmark-results-
5656

5757
- name: Move benchmark HTML
5858
if: ${{ inputs.upload == true && steps.download-bench-html.outputs.cache-hit != '' }}
59-
# exact or partial cache hit
6059
run: |
61-
mv ${{ github.workspace }}/build/benchmark_results.html ${{ github.workspace }}/build/docs_build/generated/html
60+
mv umf-repo/build/benchmark_results.html ${{github.workspace}}/build/docs_build/generated/html
6261
6362
- name: Upload artifact
6463
if: ${{ inputs.upload == true }}

0 commit comments

Comments
 (0)