Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Cross VM Wagmi WalletConnect Adapter #2072

Open
jribbink opened this issue Jan 27, 2025 · 0 comments
Open

Create Cross VM Wagmi WalletConnect Adapter #2072

jribbink opened this issue Jan 27, 2025 · 0 comments

Comments

@jribbink
Copy link
Contributor

jribbink commented Jan 27, 2025

WalletConnect requires special handling. Since dApps typically use a shared walletconnect connector/provider between every wallet, we need to make sure the namespaces are backward-compatible with EIP155 wallets.

To achieve this compatibility we should either:

  • Declare both flow and eip155 namespaces as optional
  • OR Declare flow as optional and eip155 as required (this would effectively mean mandating all FCL-WC wallets accept the eip155 namespace which is technically a breaking change to the spec but in practice Flow Wallet, as the only consumer, will not be affected)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant