Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Transaction subcribe function has incorrect type #2113

Open
tombeckenham opened this issue Feb 5, 2025 · 0 comments
Open

[BUG] Transaction subcribe function has incorrect type #2113

tombeckenham opened this issue Feb 5, 2025 · 0 comments
Labels
Bug Something isn't working

Comments

@tombeckenham
Copy link

Current Behavior

The subscribe function returned by transaction has a type of (arg0: SubscriptionCallback) => () => void. However this function returns an unsubscribe function. It is also unclear if this function throws an error on failure.

Expected Behavior

The type should return an unsubscribe function. It should also indicate if it throws an error. The other once methods should also indicate if they throw errors

Steps To Reproduce

n/a

Environment

- OS:
- Node:
- npm:

What are you currently working on that this is blocking?

No response

@tombeckenham tombeckenham added the Bug Something isn't working label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

1 participant