Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension does not respect cadence.flowCommand for determining CLI version #517

Closed
jribbink opened this issue Jan 23, 2024 · 0 comments · Fixed by #518
Closed

Extension does not respect cadence.flowCommand for determining CLI version #517

jribbink opened this issue Jan 23, 2024 · 0 comments · Fixed by #518
Assignees
@jribbink
Labels
bug Something isn't working

Comments

@jribbink
Copy link
Contributor

In the implementation of the CLI version resolver, the vscode extension executes the command flow version. This, however, does not respect a custom user-configured cadence.flowCommand setting. This should be corrected.
@jribbink jribbink added the bug Something isn't working label Jan 23, 2024
@jribbink jribbink self-assigned this Jan 23, 2024
@jribbink jribbink moved this to 🏗 In Progress in 🌊 Flow 4D Jan 23, 2024
@jribbink jribbink moved this from 🏗 In Progress to 🧊 Backlog in 🌊 Flow 4D Jan 23, 2024
@jribbink jribbink mentioned this issue Jan 23, 2024
Merged
6 tasks
@jribbink jribbink moved this from 🧊 Backlog to 👀 In review in 🌊 Flow 4D Jan 23, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in 🌊 Flow 4D Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jribbink jribbink

Labels
bug Something isn't working
Projects
🌊 Flow 4D
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor FlowVersionProvider & use cadence.flowCommand from Settings onflow/vscode-cadence
1 participant
@jribbink