Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix naming of docker images to conform to docker standards #275

Open
caoimhinuibrian opened this issue Aug 26, 2020 · 2 comments
Open

fix naming of docker images to conform to docker standards #275

caoimhinuibrian opened this issue Aug 26, 2020 · 2 comments
Assignees

Comments

@caoimhinuibrian
Copy link
Collaborator

See comments from @gongsu832 in PR #273

@caoimhinuibrian caoimhinuibrian self-assigned this Aug 26, 2020
@gongsu832
Copy link
Collaborator

@caoimhinuibrian Based on #300 I think that the onnx-milr-build image is really meant for developers since it contains both llvm-project and onnx-mlir source, which makes it fairly big. Perhaps we should also create an onnx-mlir image just for end users. It will have all binaries installed without the source code so it should be fairly small. I also have a script from DLC Classic that can be adopted to run the onnx-mlir inside the docker almost exactly as if running it directly. That should make it easy for interested users to quickly try onnx-mlir on a model by typing just one command. If you think this is worthwhile, I can work on the onnx-mlir image and the accompanying script.

@doru1004
Copy link
Collaborator

doru1004 commented Nov 6, 2020

Any updates? Please close when issue is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants