Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined datatype for attribute when importing ONNX 1.0 MNIST model #41

Open
aaronsm opened this issue Mar 20, 2020 · 2 comments
Open
Assignees

Comments

@aaronsm
Copy link
Contributor

aaronsm commented Mar 20, 2020

What version of ONNX is supported?

I tried onnx-mlir with the ONNX 1.0 MNIST model from here [1]. It looks like every node has an undefined datatype which seems wrong and crashes the tool. If I use the ONNX 1.2 MNIST model from the same website the tool works.

$ ./onnx-mlir --EmitONNXIR mnist/model.onnx -debug

ImportNode=Constant
'value' undefined
Assertion failed: (false && "datatype for attribute is not implemented"), function convertAttributeProtoToNameValuePair, file /onnx-mlir/src/Builder/FrontendDialectTransformer.cpp, line 227.

[1] https://github.com/onnx/models/tree/master/vision/classification/mnist

@aaronsm aaronsm changed the title Undefined attribute when importing ONNX 1.0 MNIST model Undefined datatype for attribute when importing ONNX 1.0 MNIST model Mar 20, 2020
@tjingrant
Copy link
Contributor

@aaronsm our current opset version support policy has been somewhat vague, the clarification of which is a work item near the top of our todo list.

We currently support only the latest opset version, and we plan to expand the scope of our support imminently. Will keep you posted on this thread.

@tjingrant tjingrant self-assigned this Mar 20, 2020
@tungld
Copy link
Collaborator

tungld commented Mar 23, 2020

Hi @aaronsm, FYI, this ONNX MNIST model opset v8, https://onnxzoo.blob.core.windows.net/models/opset_8/mnist/mnist.tar.gz, works well in the current onnx-mlir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants