Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A parser for ONNX and creating test-cases for ONNX to ONNX-MLIR translation #469

Open
gramalingam opened this issue Jan 12, 2021 · 2 comments

Comments

@gramalingam
Copy link
Contributor

It will be convenient if we could use the filecheck utility for unit-tests for the translation of ONNX to ONNX-MLIR. This will be easier to do if we have a text-based syntax for ONNX models and a parser to create an ONNX model from text.

I created a PR in the ONNX repo with a proposed syntax and parser for this purpose: please see: onnx/onnx#3194

@tjingrant
Copy link
Contributor

@gramalingam that makes a lot of sense!

One thing I had worked on (and hope to continue pushing forward with in the near future) is end-to-end tests, i.e., tests converting tensorflow/pytorch checkpoints to onnx models using converters and verify they can be parsed correctly by onnx-mlir. I believe these end-to-end conversion tests will complement the unit test suites mentioned here nicely.

Please let me and other collaborators know how best to support your effort; as a starter, I can help with upgrading the onnx submodule version once your patch is merged into the ONNX master branch.

@tungld
Copy link
Collaborator

tungld commented Jan 14, 2021

This is a good idea. It could help solve this issue #218 also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants