-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Registration and linking of dialects in onnx-mlir-opt #88
Comments
Thanks a lot for getting in touch about this. We are definitely interested in a PR! |
Great, I hope to have the permission to sign the CLA soon and will get back to this asap. |
There's also good support for importing the llvm/mlir configuration (see mlir/examples/standalone). This would greatly simplify the MLIR.cmake file. |
I know this is actually the wrong place to ask, but is there a corporate CLA we could sign? Could not find a corporate one and I am not allowed to contribute under the individual CLA. |
Thanks @stephenneuendorffer for your advice, I have been looking into this example as well and I believe these updates would be immensely helpful for us. As for corporate CLA, this is the same CLA for all repos under the ONNX organization, thus it's not up to us to decide. Let's cc @prasanthpul to see if a corporate version of the CLA is available to sign. |
…onnx Add layer_name attr to aten ops
With a more recent version of MLIR, it is no longer necessary to always link in the MLIR dialects:
onnx-mlir/src/Tool/ONNXMLIROpt/CMakeLists.txt
Line 9 in 46ef799
Further, there seems to be no need to include
InitAllDialects.h
, as the functionregisterAllDialects()
isn't called anyway. Are you interested in a PR?The text was updated successfully, but these errors were encountered: