Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registration and linking of dialects in onnx-mlir-opt #88

Open
marbre opened this issue Apr 14, 2020 · 5 comments
Open

Registration and linking of dialects in onnx-mlir-opt #88

marbre opened this issue Apr 14, 2020 · 5 comments
Labels
enhancement New feature or request.

Comments

@marbre
Copy link

marbre commented Apr 14, 2020

With a more recent version of MLIR, it is no longer necessary to always link in the MLIR dialects:

whole_archive_link_mlir(onnx-mlir-opt ${MLIRWholeArchiveLibs})

Further, there seems to be no need to include InitAllDialects.h, as the function registerAllDialects() isn't called anyway. Are you interested in a PR?

@doru1004
Copy link
Collaborator

Thanks a lot for getting in touch about this. We are definitely interested in a PR!

@marbre
Copy link
Author

marbre commented Apr 21, 2020

Great, I hope to have the permission to sign the CLA soon and will get back to this asap.

@stephenneuendorffer
Copy link
Contributor

There's also good support for importing the llvm/mlir configuration (see mlir/examples/standalone). This would greatly simplify the MLIR.cmake file.

@marbre
Copy link
Author

marbre commented Jul 17, 2020

Great, I hope to have the permission to sign the CLA soon and will get back to this asap.

I know this is actually the wrong place to ask, but is there a corporate CLA we could sign? Could not find a corporate one and I am not allowed to contribute under the individual CLA.

@tjingrant
Copy link
Contributor

Thanks @stephenneuendorffer for your advice, I have been looking into this example as well and I believe these updates would be immensely helpful for us.

As for corporate CLA, this is the same CLA for all repos under the ONNX organization, thus it's not up to us to decide. Let's cc @prasanthpul to see if a corporate version of the CLA is available to sign.

mgehre-amd referenced this issue in Xilinx/onnx-mlir Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request.
Projects
None yet
Development

No branches or pull requests

5 participants