Revert "clean up unused code and update documentation (#8)"

This reverts commit c289dba.

Author: mooorex

.github/workflows/build.yml

@@ -11,7 +11,6 @@ on:
       - master
       - main
       - develop
-      - for_new_models
   pull_request:
 
 jobs:

doc/APP_SPECIFICATION.md

@@ -184,7 +184,6 @@ The following standard Status Words are returned for all APDUs.
 
 | SW       | SW name                     | Description                                           |
 | ---      | ---                         | ---                                                   |
-|   9000   | SW_OK                  | success                                     |
 |   6985   | SW_DENY                  | Rejected by user                                      |
 |   6A86   | SW_WRONG_P1P2               | Either P1 or P2 is incorrect                          |
 |   6A87   | SW_WRONG_DATA_LENGTH        | Lc or minimum APDU length is incorrect                |
@@ -201,4 +200,5 @@ The following standard Status Words are returned for all APDUs.
 |   B008   | SW_SIGNATURE_FAIL           | Signature of data(tx or personal msg) failed            |
 |   B009   | SW_PERSONAL_MSG_PARSING_FAIL  | Failed to parse personal msg                            |
 |   B00A   | SW_INVALID_TRANSACTION  | Invalid transaction                              |
-|   B00B   | SW_INVALID_PATH  | Invalid path                              |
+|   B00B   | SW_HASH_FAILED  | Msg hash failed                              |
+|   B00C   | SW_INVALID_PATH  | Invalid path                              |

src/transaction/utils.h

@@ -5,6 +5,7 @@
 #include <stddef.h>
 #include <string.h>
 
+#include "types.h"
 #include "../types.h"
 
 /**

src/ui/nbgl_display_transaction.c

@@ -263,7 +263,7 @@ static int ui_display_normal_transaction() {
         return io_send_sw(SW_INVALID_TRANSACTION);
     }
     if (!handle_params(&G_context.tx_info.transaction, method, g_pairs, &g_pairList.nbPairs)) {
-        return io_send_sw(SW_INVALID_TRANSACTION);
+        return io_send_sw(SW_INVALID_TRANSACTION);  // todo : check all the words
     }
 
     g_pairs[g_pairList.nbPairs].item = GAS_FEE;

unit-tests/CMakeLists.txt

@@ -53,6 +53,7 @@ include_directories($ENV{BOLOS_SDK}/target/nanos2/include)
 include_directories($ENV{BOLOS_SDK}/lib_cxng/include)
 
 add_executable(test_tx_parser test_tx_parser.c)
+# add_executable(test_tx_utils test_tx_utils.c)
 
 add_library(base58 SHARED $ENV{BOLOS_SDK}/lib_standard_app/base58.c)
 add_library(bip32 SHARED $ENV{BOLOS_SDK}/lib_standard_app/bip32.c)
@@ -84,5 +85,10 @@ target_link_libraries(test_tx_parser PUBLIC
                       transaction_utils
                       transaction_contract)
 
+# target_link_libraries(test_tx_utils PUBLIC
+#                       cmocka
+#                       gcov
+#                       transaction_utils)
 
-add_test(test_tx_parser test_tx_parser)
+add_test(test_tx_parser test_tx_parser)
+#add_test(test_tx_utils test_tx_utils)

unit-tests/test_tx_parser.c

@@ -10,7 +10,16 @@
 
 #include "transaction/deserialize.h"
 #include "transaction/parse.h"
-
+#include "types.h"
+
+size_t strlcpy(char *dst, const char *src, size_t size) {
+    size_t src_len = strlen(src);
+    if (size == 0) return src_len;
+    size_t copy_len = (src_len >= size) ? size - 1 : src_len;
+    memcpy(dst, src, copy_len);
+    dst[copy_len] = '\0';
+    return src_len;
+}
 
 static void test_tx_gov_withdraw_parser(void **state) {
     (void) state;

unit-tests/test_tx_utils.c

@@ -0,0 +1,38 @@
+#include <stdarg.h>
+#include <stddef.h>
+#include <setjmp.h>
+#include <stdint.h>
+#include <stdbool.h>
+#include <string.h>
+
+#include <cmocka.h>
+
+#include "transaction/utils.h"
+#include "types.h"
+
+static void test_tx_utils(void **state) {
+    (void) state;
+
+    const uint8_t good_ascii[] = {0x48, 0x65, 0x6c, 0x6c, 0x6f, 0x21};  // Hello!
+    const uint8_t bad_ascii[] = {0x32, 0xc3, 0x97, 0x32, 0x3d, 0x34};   // 2×2=4
+
+    assert_true(transaction_utils_check_encoding(good_ascii, sizeof(good_ascii)));
+    assert_false(transaction_utils_check_encoding(bad_ascii, sizeof(bad_ascii)));
+
+    char output[MAX_MEMO_LEN] = {0};
+    assert_true(transaction_utils_format_memo(good_ascii,          //
+                                              sizeof(good_ascii),  //
+                                              output,              //
+                                              sizeof(output)));
+    assert_string_equal(output, "Hello!");
+    assert_false(transaction_utils_format_memo(good_ascii,            //
+                                               sizeof(good_ascii),    //
+                                               output,                //
+                                               sizeof(good_ascii)));  // dst_len too small
+}
+
+int main() {
+    const struct CMUnitTest tests[] = {cmocka_unit_test(test_tx_utils)};
+
+    return cmocka_run_group_tests(tests, NULL, NULL);
+}