Skip to content

Commit ed4ad88

Browse files
committed
Fix changepoint positioning
1 parent e7ee0cf commit ed4ad88

1 file changed

Lines changed: 6 additions & 15 deletions

File tree

components/chart/AlertChart.tsx

Lines changed: 6 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -93,13 +93,13 @@ export const transformAnalysisToChartData = (
9393
const ChangepointLines = ({
9494
changepoints,
9595
innerHeight,
96-
marginTop,
96+
// marginTop,
9797
innerWidth,
9898
series,
9999
}: {
100100
changepoints: Changepoint[] | undefined
101101
innerHeight: number
102-
marginTop: number
102+
// marginTop: number
103103
innerWidth: number
104104
series: ReadonlyArray<{ data: ReadonlyArray<{ data: { x: string | Date } }> }>
105105
}) => {
@@ -138,18 +138,9 @@ const ChangepointLines = ({
138138
return (
139139
<g>
140140
{changepoints.map((changepoint) => {
141-
// Convert start_time to Date object
142141
const startDate = new Date(changepoint.start_time)
143-
// Extract just the date part (set to midnight UTC) to match measurement_start_day format
144-
const dateOnly = new Date(
145-
Date.UTC(
146-
startDate.getUTCFullYear(),
147-
startDate.getUTCMonth(),
148-
startDate.getUTCDate(),
149-
),
150-
)
151142

152-
const x = xScale(dateOnly)
143+
const x = xScale(startDate)
153144

154145
if (Number.isNaN(x) || x < 0 || x > innerWidth) {
155146
return null
@@ -202,7 +193,7 @@ const Chart = ({
202193
xScale={{
203194
type: 'time',
204195
format: '%Y-%m-%dT%H:%M:%SZ',
205-
precision: 'minute',
196+
precision: 'hour',
206197
useUTC: true,
207198
}}
208199
yScale={{
@@ -219,11 +210,11 @@ const Chart = ({
219210
'grid',
220211
'axes',
221212
'lines',
222-
({ innerHeight, margin, innerWidth, series }) => (
213+
({ innerHeight, innerWidth, series }) => (
223214
<ChangepointLines
224215
changepoints={changepoints}
225216
innerHeight={innerHeight}
226-
marginTop={margin.top ?? 0}
217+
// marginTop={margin.top ?? 0}
227218
innerWidth={innerWidth}
228219
series={series}
229220
/>

0 commit comments

Comments
 (0)