Use lodash.create instead of underscore.clone

Author: oozcitak

src/XMLAttribute.coffee

@@ -21,6 +21,11 @@ module.exports = class XMLAttribute
     @value = @stringify.attValue value
 
 
+  # Creates and returns a deep clone of `this`
+  clone: () ->
+    _.create XMLAttribute.prototype, @
+
+
   # Converts the XML fragment to string
   #
   # `options.pretty` pretty prints the result

src/XMLCData.coffee

@@ -18,6 +18,11 @@ module.exports = class XMLCData extends XMLNode
     @text = @stringify.cdata text
 
 
+  # Creates and returns a deep clone of `this`
+  clone: () ->
+    _.create XMLCData.prototype, @
+
+
   # Converts the XML fragment to string
   #
   # `options.pretty` pretty prints the result

src/XMLComment.coffee

@@ -18,6 +18,11 @@ module.exports = class XMLComment extends XMLNode
     @text = @stringify.comment text
 
 
+  # Creates and returns a deep clone of `this`
+  clone: () ->
+    _.create XMLComment.prototype, @
+
+
   # Converts the XML fragment to string
   #
   # `options.pretty` pretty prints the result

src/XMLDTDAttList.coffee

@@ -39,6 +39,11 @@ module.exports = class XMLDTDAttList
     @defaultValueType = defaultValueType
 
 
+  # Creates and returns a deep clone of `this`
+  clone: () ->
+    _.create XMLDTDAttList.prototype, @
+
+
   # Converts the XML fragment to string
   #
   # `options.pretty` pretty prints the result

src/XMLDTDElement.coffee

@@ -23,6 +23,11 @@ module.exports = class XMLDTDElement
     @value = @stringify.dtdElementValue value
 
 
+  # Creates and returns a deep clone of `this`
+  clone: () ->
+    _.create XMLDTDElement.prototype, @
+
+
   # Converts the XML fragment to string
   #
   # `options.pretty` pretty prints the result

src/XMLDTDEntity.coffee

@@ -41,6 +41,11 @@ module.exports = class XMLDTDEntity
         throw new Error "Notation declaration is not allowed in a parameter entity"
 
 
+  # Creates and returns a deep clone of `this`
+  clone: () ->
+    _.create XMLDTDEntity.prototype, @
+
+
   # Converts the XML fragment to string
   #
   # `options.pretty` pretty prints the result

src/XMLDTDNotation.coffee

@@ -23,6 +23,12 @@ module.exports = class XMLDTDNotation
     @pubID = @stringify.dtdPubID value.pubID if value.pubID?
     @sysID = @stringify.dtdSysID value.sysID if value.sysID?
 
+
+  # Creates and returns a deep clone of `this`
+  clone: () ->
+    _.create XMLDTDNotation.prototype, @
+
+
   # Converts the XML fragment to string
   #
   # `options.pretty` pretty prints the result

src/XMLDeclaration.coffee

@@ -32,6 +32,11 @@ module.exports = class XMLDeclaration extends XMLNode
       @standalone = @stringify.xmlStandalone standalone
 
 
+  # Creates and returns a deep clone of `this`
+  clone: () ->
+    _.create XMLDeclaration.prototype, @
+
+
   # Converts to string
   #
   # `options.pretty` pretty prints the result

src/XMLDocType.coffee

@@ -27,6 +27,11 @@ module.exports = class XMLDocType
     @sysID = @stringify.dtdSysID sysID if sysID?
 
 
+  # Creates and returns a deep clone of `this`
+  clone: () ->
+    _.create XMLDocType.prototype, @
+
+
   # Creates an element type declaration
   #
   # `name` element name

src/XMLElement.coffee

@@ -27,30 +27,27 @@ module.exports = class XMLElement extends XMLNode
     @attribute attributes if attributes?
 
 
-  # Clones self
+  # Creates and returns a deep clone of `this`
   #
-  # `deep` true to clone child nodes as well
-  clone: (deep) ->
-    # shallow copy
-    clonedSelf = _.clone @
+  clone: () ->
+    clonedSelf = _.create XMLElement.prototype, @
 
     # clone attributes
     clonedSelf.attributes = {}
     for own attName, att of @attributes
-      clonedSelf.attributes[attName] = _.clone att
+      clonedSelf.attributes[attName] = att.clone()
 
     # clone processing instructions
     clonedSelf.instructions = []
     for pi in @instructions
-      clonedSelf.instructions.push _.clone pi
+      clonedSelf.instructions.push pi.clone()
 
-    clonedSelf.children = []
     # clone child nodes
-    if deep
-      @children.forEach (child) ->
-        clonedChild = child.clone(deep)
-        clonedChild.parent = clonedSelf
-        clonedSelf.children.push clonedChild
+    clonedSelf.children = []
+    @children.forEach (child) ->
+      clonedChild = child.clone()
+      clonedChild.parent = clonedSelf
+      clonedSelf.children.push clonedChild
 
     return clonedSelf
 

src/XMLNode.coffee

@@ -12,6 +12,11 @@ module.exports = class XMLNode
     @stringify = @parent.stringify
 
 
+  # Creates and returns a deep clone of `this`
+  clone: () ->
+    throw new Error "Cannot clone generic XMLNode"
+
+
   # Creates a child element node
   #
   # `name` node name or an object describing the XML tree
@@ -277,20 +282,13 @@ module.exports = class XMLNode
   #
   # `xmlbuilder` the instance of XMLBuilder to insert nodes from
   importXMLBuilder: (xmlbuilder) ->
-    clonedRoot = xmlbuilder.root().clone(true)
+    clonedRoot = xmlbuilder.root().clone()
     clonedRoot.parent = @
-    @children.push clonedRoot
     clonedRoot.isRoot = false
+    @children.push clonedRoot
     return @
 
 
-  # Clones self
-  #
-  # `deep` true to clone child nodes as well
-  clone: (deep) ->
-    _.clone @
-
-
   # Aliases
   ele: (name, attributes, text) -> @element name, attributes, text
   nod: (name, attributes, text) -> @node name, attributes, text

src/XMLProcessingInstruction.coffee

@@ -19,6 +19,11 @@ module.exports = class XMLProcessingInstruction
     @value = @stringify.insValue value if value
 
 
+  # Creates and returns a deep clone of `this`
+  clone: () ->
+    _.create XMLProcessingInstruction.prototype, @
+
+
   # Converts the XML fragment to string
   #
   # `options.pretty` pretty prints the result

src/XMLRaw.coffee

@@ -18,6 +18,11 @@ module.exports = class XMLRaw extends XMLNode
     @value = @stringify.raw text
 
 
+  # Creates and returns a deep clone of `this`
+  clone: () ->
+    _.create XMLRaw.prototype, @
+
+
   # Converts the XML fragment to string
   #
   # `options.pretty` pretty prints the result

src/XMLText.coffee

@@ -18,6 +18,11 @@ module.exports = class XMLText extends XMLNode
     @value = @stringify.eleText text
 
 
+  # Creates and returns a deep clone of `this`
+  clone: () ->
+    _.create XMLText.prototype, @
+
+
   # Converts the XML fragment to string
   #
   # `options.pretty` pretty prints the result

test/clone.coffee

@@ -6,28 +6,7 @@ xmlbuilder = require '../src/index.coffee'
 vows
     .describe('Clone')
     .addBatch
-        'Test the clone() method (not deep clone)':
-            topic: () ->
-                test = xmlbuilder.create('test11', {}, {}, { headless: true})
-                    .att('att', 'val')
-                    .ele('nodes')
-                        .ele('node', '1')
-                    .root()
-
-                testcloned = test.root().clone()
-                testcloned.ele('added', '3')
-
-                { original: test, cloned: testcloned }
-
-            'resulting XML':
-                'original should remain unchanged': (topic) ->
-                    xml = '<test11 att="val"><nodes><node>1</node></nodes></test11>'
-                    assert.strictEqual topic.original.doc().toString(), xml
-                'cloned should contain added node only': (topic) ->
-                    xml = '<test11 att="val"><added>3</added></test11>'
-                    assert.strictEqual topic.cloned.toString(), xml
-
-        'Test the clone() method (deep clone)':
+        'Test the clone() method':
             topic: () ->
                 test = xmlbuilder.create('test11', {}, {}, { headless: true})
                     .att('att', 'val')
@@ -37,7 +16,7 @@ vows
                             .att('att2', 'val2')
                     .root()
 
-                testcloned = test.root().clone(true)
+                testcloned = test.root().clone()
                 testcloned.ele('added', '3')
 
                 { original: test, cloned: testcloned }