Skip to content

Commit 765ebda

Browse files
committed
fix ruff issues
1 parent 6fb1796 commit 765ebda

14 files changed

+56
-36
lines changed

component_check_relevant_all_registry.ipynb

+8-4
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,13 @@
4141
"outputs": [],
4242
"source": [
4343
"non_frozen_publications = list(filter(lambda item: not item[\"frozen\"] and item[\"date_to\"], publications))\n",
44-
"past_year = datetime.now() - relativedelta(years=1)\n",
44+
"today = datetime.now(tz=timezone.utc)\n",
45+
"past_year = today - relativedelta(years=1)\n",
4546
"lapsed_publications = list(\n",
46-
" filter(lambda item: datetime.strptime(item[\"date_to\"], \"%Y-%m-%d\") < past_year, non_frozen_publications)\n",
47+
" filter(\n",
48+
" lambda item: datetime.strptime(item[\"date_to\"], \"%Y-%m-%d\").astimezone(timezone.utc) < past_year,\n",
49+
" non_frozen_publications,\n",
50+
" )\n",
4751
")\n",
4852
"lapsed_publications_table = pd.DataFrame(lapsed_publications)\n",
4953
"lapsed_publications_table"
@@ -71,8 +75,8 @@
7175
"active_publications = [item for item in non_frozen_publications if item not in lapsed_publications]\n",
7276
"for publication in active_publications:\n",
7377
" year = publication[\"date_to\"][:4]\n",
74-
" if int(year) > datetime.now().year:\n",
75-
" year = datetime.now().year\n",
78+
" if int(year) > today.year:\n",
79+
" year = today.year\n",
7680
" file_name = download_file(publication, year)\n",
7781
" field_table = cardinal_calculate_coverage(file_name)\n",
7882
" fields_list = field_table.iloc[:, 0].tolist()\n",

component_environment.ipynb

+3-2
Original file line numberDiff line numberDiff line change
@@ -55,11 +55,12 @@
5555
"import shutil\n",
5656
"import tempfile\n",
5757
"from collections import Counter\n",
58+
"from datetime import datetime, timezone\n",
59+
"from pathlib import Path\n",
5860
"\n",
59-
"from datetime import datetime\n",
60-
"from dateutil.relativedelta import relativedelta\n",
6161
"import numpy as np\n",
6262
"import pandas as pd\n",
63+
"from dateutil.relativedelta import relativedelta\n",
6364
"from google.colab.data_table import DataTable\n",
6465
"from google.colab.files import download\n",
6566
"from ipywidgets import widgets\n",

component_setup_download_data_from_registry.ipynb

+1-1
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@
8181
" response = requests.get(download_url, timeout=10)\n",
8282
" with tempfile.NamedTemporaryFile() as gz_file:\n",
8383
" gz_file.write(response.content)\n",
84-
" with gzip.open(gz_file.name) as i, open(file_name, \"wb\") as o:\n",
84+
" with gzip.open(gz_file.name) as i, Path(file_name).open(\"wb\") as o:\n",
8585
" shutil.copyfileobj(i, o)\n",
8686
" return file_name"
8787
]

template_basic_criteria_checks.ipynb

+3-2
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,12 @@
4848
"import shutil\n",
4949
"import tempfile\n",
5050
"from collections import Counter\n",
51+
"from datetime import datetime, timezone\n",
52+
"from pathlib import Path\n",
5153
"\n",
52-
"from datetime import datetime\n",
53-
"from dateutil.relativedelta import relativedelta\n",
5454
"import numpy as np\n",
5555
"import pandas as pd\n",
56+
"from dateutil.relativedelta import relativedelta\n",
5657
"from google.colab.data_table import DataTable\n",
5758
"from google.colab.files import download\n",
5859
"from ipywidgets import widgets\n",

template_data_quality_feedback.ipynb

+3-2
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,12 @@
4848
"import shutil\n",
4949
"import tempfile\n",
5050
"from collections import Counter\n",
51+
"from datetime import datetime, timezone\n",
52+
"from pathlib import Path\n",
5153
"\n",
52-
"from datetime import datetime\n",
53-
"from dateutil.relativedelta import relativedelta\n",
5454
"import numpy as np\n",
5555
"import pandas as pd\n",
56+
"from dateutil.relativedelta import relativedelta\n",
5657
"from google.colab.data_table import DataTable\n",
5758
"from google.colab.files import download\n",
5859
"from ipywidgets import widgets\n",

template_meta_analysis.ipynb

+3-2
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,12 @@
4848
"import shutil\n",
4949
"import tempfile\n",
5050
"from collections import Counter\n",
51+
"from datetime import datetime, timezone\n",
52+
"from pathlib import Path\n",
5153
"\n",
52-
"from datetime import datetime\n",
53-
"from dateutil.relativedelta import relativedelta\n",
5454
"import numpy as np\n",
5555
"import pandas as pd\n",
56+
"from dateutil.relativedelta import relativedelta\n",
5657
"from google.colab.data_table import DataTable\n",
5758
"from google.colab.files import download\n",
5859
"from ipywidgets import widgets\n",

template_publisher_analysis.ipynb

+3-2
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,12 @@
4848
"import shutil\n",
4949
"import tempfile\n",
5050
"from collections import Counter\n",
51+
"from datetime import datetime, timezone\n",
52+
"from pathlib import Path\n",
5153
"\n",
52-
"from datetime import datetime\n",
53-
"from dateutil.relativedelta import relativedelta\n",
5454
"import numpy as np\n",
5555
"import pandas as pd\n",
56+
"from dateutil.relativedelta import relativedelta\n",
5657
"from google.colab.data_table import DataTable\n",
5758
"from google.colab.files import download\n",
5859
"from ipywidgets import widgets\n",

template_relevant_checks_fieldlist.ipynb

+3-2
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,12 @@
4848
"import shutil\n",
4949
"import tempfile\n",
5050
"from collections import Counter\n",
51+
"from datetime import datetime, timezone\n",
52+
"from pathlib import Path\n",
5153
"\n",
52-
"from datetime import datetime\n",
53-
"from dateutil.relativedelta import relativedelta\n",
5454
"import numpy as np\n",
5555
"import pandas as pd\n",
56+
"from dateutil.relativedelta import relativedelta\n",
5657
"from google.colab.data_table import DataTable\n",
5758
"from google.colab.files import download\n",
5859
"from ipywidgets import widgets\n",

template_relevant_checks_registry.ipynb

+4-3
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,12 @@
4848
"import shutil\n",
4949
"import tempfile\n",
5050
"from collections import Counter\n",
51+
"from datetime import datetime, timezone\n",
52+
"from pathlib import Path\n",
5153
"\n",
52-
"from datetime import datetime\n",
53-
"from dateutil.relativedelta import relativedelta\n",
5454
"import numpy as np\n",
5555
"import pandas as pd\n",
56+
"from dateutil.relativedelta import relativedelta\n",
5657
"from google.colab.data_table import DataTable\n",
5758
"from google.colab.files import download\n",
5859
"from ipywidgets import widgets\n",
@@ -861,7 +862,7 @@
861862
" response = requests.get(download_url, timeout=10)\n",
862863
" with tempfile.NamedTemporaryFile() as gz_file:\n",
863864
" gz_file.write(response.content)\n",
864-
" with gzip.open(gz_file.name) as i, open(file_name, \"wb\") as o:\n",
865+
" with gzip.open(gz_file.name) as i, Path(file_name).open(\"wb\") as o:\n",
865866
" shutil.copyfileobj(i, o)\n",
866867
" return file_name"
867868
]

template_relevant_checks_registry_all.ipynb

+12-7
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,12 @@
4848
"import shutil\n",
4949
"import tempfile\n",
5050
"from collections import Counter\n",
51+
"from datetime import datetime, timezone\n",
52+
"from pathlib import Path\n",
5153
"\n",
52-
"from datetime import datetime\n",
53-
"from dateutil.relativedelta import relativedelta\n",
5454
"import numpy as np\n",
5555
"import pandas as pd\n",
56+
"from dateutil.relativedelta import relativedelta\n",
5657
"from google.colab.data_table import DataTable\n",
5758
"from google.colab.files import download\n",
5859
"from ipywidgets import widgets\n",
@@ -861,7 +862,7 @@
861862
" response = requests.get(download_url, timeout=10)\n",
862863
" with tempfile.NamedTemporaryFile() as gz_file:\n",
863864
" gz_file.write(response.content)\n",
864-
" with gzip.open(gz_file.name) as i, open(file_name, \"wb\") as o:\n",
865+
" with gzip.open(gz_file.name) as i, Path(file_name).open(\"wb\") as o:\n",
865866
" shutil.copyfileobj(i, o)\n",
866867
" return file_name"
867868
]
@@ -910,9 +911,13 @@
910911
"outputs": [],
911912
"source": [
912913
"non_frozen_publications = list(filter(lambda item: not item[\"frozen\"] and item[\"date_to\"], publications))\n",
913-
"past_year = datetime.now() - relativedelta(years=1)\n",
914+
"today = datetime.now(tz=timezone.utc)\n",
915+
"past_year = today - relativedelta(years=1)\n",
914916
"lapsed_publications = list(\n",
915-
" filter(lambda item: datetime.strptime(item[\"date_to\"], \"%Y-%m-%d\") < past_year, non_frozen_publications)\n",
917+
" filter(\n",
918+
" lambda item: datetime.strptime(item[\"date_to\"], \"%Y-%m-%d\").astimezone(timezone.utc) < past_year,\n",
919+
" non_frozen_publications,\n",
920+
" )\n",
916921
")\n",
917922
"lapsed_publications_table = pd.DataFrame(lapsed_publications)\n",
918923
"lapsed_publications_table"
@@ -940,8 +945,8 @@
940945
"active_publications = [item for item in non_frozen_publications if item not in lapsed_publications]\n",
941946
"for publication in active_publications:\n",
942947
" year = publication[\"date_to\"][:4]\n",
943-
" if int(year) > datetime.now().year:\n",
944-
" year = datetime.now().year\n",
948+
" if int(year) > today.year:\n",
949+
" year = today.year\n",
945950
" file_name = download_file(publication, year)\n",
946951
" field_table = cardinal_calculate_coverage(file_name)\n",
947952
" fields_list = field_table.iloc[:, 0].tolist()\n",

template_structure_and_format_feedback.ipynb

+3-2
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,12 @@
4848
"import shutil\n",
4949
"import tempfile\n",
5050
"from collections import Counter\n",
51+
"from datetime import datetime, timezone\n",
52+
"from pathlib import Path\n",
5153
"\n",
52-
"from datetime import datetime\n",
53-
"from dateutil.relativedelta import relativedelta\n",
5454
"import numpy as np\n",
5555
"import pandas as pd\n",
56+
"from dateutil.relativedelta import relativedelta\n",
5657
"from google.colab.data_table import DataTable\n",
5758
"from google.colab.files import download\n",
5859
"from ipywidgets import widgets\n",

template_usability_checks.ipynb

+3-2
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,12 @@
4848
"import shutil\n",
4949
"import tempfile\n",
5050
"from collections import Counter\n",
51+
"from datetime import datetime, timezone\n",
52+
"from pathlib import Path\n",
5153
"\n",
52-
"from datetime import datetime\n",
53-
"from dateutil.relativedelta import relativedelta\n",
5454
"import numpy as np\n",
5555
"import pandas as pd\n",
56+
"from dateutil.relativedelta import relativedelta\n",
5657
"from google.colab.data_table import DataTable\n",
5758
"from google.colab.files import download\n",
5859
"from ipywidgets import widgets\n",

template_usability_checks_fieldlist.ipynb

+3-2
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,12 @@
4848
"import shutil\n",
4949
"import tempfile\n",
5050
"from collections import Counter\n",
51+
"from datetime import datetime, timezone\n",
52+
"from pathlib import Path\n",
5153
"\n",
52-
"from datetime import datetime\n",
53-
"from dateutil.relativedelta import relativedelta\n",
5454
"import numpy as np\n",
5555
"import pandas as pd\n",
56+
"from dateutil.relativedelta import relativedelta\n",
5657
"from google.colab.data_table import DataTable\n",
5758
"from google.colab.files import download\n",
5859
"from ipywidgets import widgets\n",

template_usability_checks_registry.ipynb

+4-3
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,12 @@
4848
"import shutil\n",
4949
"import tempfile\n",
5050
"from collections import Counter\n",
51+
"from datetime import datetime, timezone\n",
52+
"from pathlib import Path\n",
5153
"\n",
52-
"from datetime import datetime\n",
53-
"from dateutil.relativedelta import relativedelta\n",
5454
"import numpy as np\n",
5555
"import pandas as pd\n",
56+
"from dateutil.relativedelta import relativedelta\n",
5657
"from google.colab.data_table import DataTable\n",
5758
"from google.colab.files import download\n",
5859
"from ipywidgets import widgets\n",
@@ -524,7 +525,7 @@
524525
" response = requests.get(download_url, timeout=10)\n",
525526
" with tempfile.NamedTemporaryFile() as gz_file:\n",
526527
" gz_file.write(response.content)\n",
527-
" with gzip.open(gz_file.name) as i, open(file_name, \"wb\") as o:\n",
528+
" with gzip.open(gz_file.name) as i, Path(file_name).open(\"wb\") as o:\n",
528529
" shutil.copyfileobj(i, o)\n",
529530
" return file_name"
530531
]

0 commit comments

Comments
 (0)