XML type definition for EntityAssociationVP associationStatus

[brutzman]

Ken H. reported a problem with

• https://github.com/open-dis/opendis7-source-generator/blob/master/xml/dis_7_2012/DIS_7_2012.xml

Lines 2720-2722:

        <attribute name="associationStatus" comment="Indicates association status between two entities">
            <sisoenum type="EntityAssociationAssociationType" comment="uid 319"/>
        </attribute>

Problem: "EntityAssociationAssociationType" is already defined as uid 330 on line 271.

Plausible change is to uniquely rename the type:

        <attribute name="associationStatus" comment="Indicates association status between two entities">
            <sisoenum type="EntityAssociationAssociationStatus" comment="uid 319"/>
        </attribute>

Relevant DIS specification excerpt:

• IEEE standard 1278.1-2012 page 330
• 6.2.94.4 Entity Association VP Record
• 6.2.94.4.3 Fields
• c) Association Status. This field shall indicate the association status between two entities, or an entity with another object. It shall be represented by an 8-bit enumeration (see [UID 319]).

[brutzman]

have applied change above (EntityAssociationAssociationType to EntityAssociationAssociationStatus) to line 2721 of DIS_7_2012.xml locally, testing in progress...

[brutzman]

Looking ahead, since this error exists and was not previously detected, we must not have a diagnostic check in the source-generator. I would expect that it belongs in edu.nps.moves.dis7.source.generator.entityTypes.GenerateEntityTypes following lines 75-82

/** Constructor for GenerateEntityTypes
     * @param xmlFile sisoXmlFile
     * @param outputDir outputDirectoryPath
     * @param packageName key to package name for entity types */
  public GenerateEntityTypes(String xmlFile, String outputDir, String packageName)
  {
        if (!xmlFile.isEmpty())
             sisoXmlFile = xmlFile;

I added the following source line immediately afterwards for some future OpenDis hero or heroine:

• // TODO: add diagnostic to ensure no duplicated sisoenum type names or entity uid numbers