Skip to content

Add new test suite for hooks / context merging #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
toddbaert opened this issue Nov 9, 2022 · 1 comment
Open

Add new test suite for hooks / context merging #13

toddbaert opened this issue Nov 9, 2022 · 1 comment
Labels
contribfest A good issue for Contribfest KubeCon EU '24 enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@toddbaert
Copy link
Member

toddbaert commented Nov 9, 2022 •
edited
Loading

The current evaluation.feature suite does a good job covering the basic behavior concerning providers / evaluation API, but things like context merging precedence and hook behavior aren't really tested here.

We should create a new suite that tests some of the above.
@toddbaert toddbaert added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Nov 9, 2022
@toddbaert toddbaert added the contribfest A good issue for Contribfest KubeCon EU '24 label Mar 15, 2024
@chrfwow
Copy link
Contributor

chrfwow commented Feb 5, 2025

Do you consider the tests introduced with open-feature/spec#290 to be covering the hook behaviour?

@chrfwow chrfwow mentioned this issue Feb 7, 2025
Merged
toddbaert added a commit to open-feature/spec that referenced this issue Mar 6, 2025
@chrfwow @toddbaert
feat: Add new test suite for context merging (#293)
25c57ee 
## This PR
Adds gherkin tests to verify the merging order of contexts:
https://openfeature.dev/specification/sections/evaluation-context/#requirement-323

See open-feature/flagd-testbed#13

---------

Signed-off-by: christian.lutnik <[email protected]>
Co-authored-by: Todd Baert <[email protected]>
@chrfwow chrfwow mentioned this issue Mar 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contribfest A good issue for Contribfest KubeCon EU '24 enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chrfwow @toddbaert