Skip to content

Commit 1605f5b

Browse files
committed
Replaced locally defined feature flag attribute constants in the telemetry package with references to OpenTelemetry semantic conventions (semconv).
Reduces maintenance and ensures alignment with OTel updates. Removes redundant constant definitions. Signed-off-by: Abishek Kafle <[email protected]>
1 parent accf2cd commit 1605f5b

File tree

1 file changed

+11
-12
lines changed

1 file changed

+11
-12
lines changed

openfeature/telemetry/telemetry.go

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,8 @@ package telemetry
33

44
import (
55
"strings"
6-
76
"github.com/open-feature/go-sdk/openfeature"
8-
semconv "go.opentelemetry.io/otel/semconv/v1.34.0"
7+
semconv "go.opentelemetry.io/otel/semconv/v1.25.0"
98
)
109

1110
// EvaluationEvent represents an event that is emitted when a flag is evaluated.
@@ -26,16 +25,16 @@ type EvaluationEvent struct {
2625

2726
// Use OTel semconv constants for feature flag attributes.
2827
const (
29-
FlagKey = semconv.FeatureFlagKeyKey
30-
ErrorTypeKey = semconv.ErrorTypeKey
31-
ResultValueKey = semconv.FeatureFlagResultValueKey
32-
ResultVariantKey = semconv.FeatureFlagResultVariantKey
33-
ErrorMessageKey = semconv.ErrorMessageKey
34-
ContextIDKey = semconv.FeatureFlagContextIDKey
35-
ProviderNameKey = semconv.FeatureFlagProviderNameKey
36-
ResultReasonKey = semconv.FeatureFlagResultReasonKey
37-
FlagSetIDKey = semconv.FeatureFlagSetIDKey
38-
VersionKey = semconv.FeatureFlagVersionKey
28+
FlagKey = semconv.FeatureFlagKeyKey
29+
ErrorTypeKey = semconv.ErrorTypeKey
30+
ResultValueKey = semconv.FeatureFlagResultValueKey
31+
ResultVariantKey = semconv.FeatureFlagResultVariantKey
32+
ErrorMessageKey = semconv.ErrorMessageKey
33+
ContextIDKey = semconv.FeatureFlagContextIDKey
34+
ProviderNameKey = semconv.FeatureFlagProviderNameKey
35+
ResultReasonKey = semconv.FeatureFlagResultReasonKey
36+
FlagSetIDKey = semconv.FeatureFlagSetIDKey
37+
VersionKey = semconv.FeatureFlagVersionKey
3938
)
4039

4140
// FlagEvaluationKey is the name of the feature flag evaluation event.

0 commit comments

Comments
 (0)